Bug 193708 - Minor improvements to NetworkProcess
Summary: Minor improvements to NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-22 21:39 PST by Michael Catanzaro
Modified: 2019-01-23 11:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.21 KB, patch)
2019-01-22 21:41 PST, Michael Catanzaro
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-01-22 21:39:04 PST
I spent a lot of time looking at NetworkProcess.cpp today and found a couple minor things to improve.
Comment 1 Michael Catanzaro 2019-01-22 21:41:28 PST
Created attachment 359851 [details]
Patch
Comment 2 Alex Christensen 2019-01-23 10:58:36 PST
Comment on attachment 359851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359851&action=review

Cool

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:539
> +        platformCreateDefaultStorageSession();
> +        ASSERT(m_defaultNetworkStorageSession);

This would be more obvious if it were m_defaultNetworkStorageSession = platformCreateDefaultStorageSession();
Comment 3 Michael Catanzaro 2019-01-23 11:02:16 PST
(In reply to Alex Christensen from comment #2)
> This would be more obvious if it were m_defaultNetworkStorageSession =
> platformCreateDefaultStorageSession();

Yes indeed, I'll land it that way.
Comment 4 Michael Catanzaro 2019-01-23 11:19:02 PST
Committed r240350: <https://trac.webkit.org/changeset/240350>
Comment 5 Radar WebKit Bug Importer 2019-01-23 11:20:29 PST
<rdar://problem/47487277>