RESOLVED FIXED193708
Minor improvements to NetworkProcess 
https://bugs.webkit.org/show_bug.cgi?id=193708
Summary Minor improvements to NetworkProcess
Michael Catanzaro
Reported 2019-01-22 21:39:04 PST
I spent a lot of time looking at NetworkProcess.cpp today and found a couple minor things to improve.
Attachments
Patch (7.21 KB, patch)
2019-01-22 21:41 PST, Michael Catanzaro 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-01-22 21:41:28 PST
Created attachment 359851 [details] Patch
Alex Christensen
Comment 2 2019-01-23 10:58:36 PST
Comment on attachment 359851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359851&action=review Cool > Source/WebKit/NetworkProcess/NetworkProcess.cpp:539 > + platformCreateDefaultStorageSession(); > + ASSERT(m_defaultNetworkStorageSession); This would be more obvious if it were m_defaultNetworkStorageSession = platformCreateDefaultStorageSession();
Michael Catanzaro
Comment 3 2019-01-23 11:02:16 PST
(In reply to Alex Christensen from comment #2) > This would be more obvious if it were m_defaultNetworkStorageSession = > platformCreateDefaultStorageSession(); Yes indeed, I'll land it that way.
Michael Catanzaro
Comment 4 2019-01-23 11:19:02 PST
Committed r240350: <https://trac.webkit.org/changeset/240350>
Radar WebKit Bug Importer
Comment 5 2019-01-23 11:20:29 PST
<rdar://problem/47487277>
Note You need to log in before you can comment on or make changes to this bug.