WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193699
Compositing updates need to reparent scrolling tree nodes with a changed ancestor
https://bugs.webkit.org/show_bug.cgi?id=193699
Summary
Compositing updates need to reparent scrolling tree nodes with a changed ance...
Simon Fraser (smfr)
Reported
2019-01-22 17:49:54 PST
Compositing updates need to reparent scrolling tree nodes with a changed ancestor
Attachments
Patch
(24.70 KB, patch)
2019-01-22 17:52 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews103 for mac-highsierra
(2.56 MB, application/zip)
2019-01-22 18:36 PST
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews112 for mac-highsierra
(2.51 MB, application/zip)
2019-01-22 19:59 PST
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews204 for win-future
(12.82 MB, application/zip)
2019-01-22 21:47 PST
,
EWS Watchlist
no flags
Details
Patch
(24.70 KB, patch)
2019-01-22 21:55 PST
,
Simon Fraser (smfr)
fred.wang
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2019-01-22 17:52:18 PST
Created
attachment 359822
[details]
Patch
EWS Watchlist
Comment 2
2019-01-22 18:36:31 PST
Comment hidden (obsolete)
Comment on
attachment 359822
[details]
Patch
Attachment 359822
[details]
did not pass mac-ews (mac): Output:
https://webkit-queues.webkit.org/results/10849168
New failing tests: scrollingcoordinator/reparent-across-compositing-layers.html scrollingcoordinator/reparent-with-layer-removal.html
EWS Watchlist
Comment 3
2019-01-22 18:36:32 PST
Comment hidden (obsolete)
Created
attachment 359831
[details]
Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 4
2019-01-22 19:59:38 PST
Comment hidden (obsolete)
Comment on
attachment 359822
[details]
Patch
Attachment 359822
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/10849768
New failing tests: scrollingcoordinator/reparent-across-compositing-layers.html scrollingcoordinator/reparent-with-layer-removal.html
EWS Watchlist
Comment 5
2019-01-22 19:59:40 PST
Comment hidden (obsolete)
Created
attachment 359841
[details]
Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 6
2019-01-22 21:46:57 PST
Comment hidden (obsolete)
Comment on
attachment 359822
[details]
Patch
Attachment 359822
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/10851349
New failing tests: scrollingcoordinator/reparent-across-compositing-layers.html scrollingcoordinator/reparent-with-layer-removal.html
EWS Watchlist
Comment 7
2019-01-22 21:47:08 PST
Comment hidden (obsolete)
Created
attachment 359852
[details]
Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Simon Fraser (smfr)
Comment 8
2019-01-22 21:55:27 PST
Created
attachment 359854
[details]
Patch
Frédéric Wang (:fredw)
Comment 9
2019-01-23 01:07:25 PST
Comment on
attachment 359854
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=359854&action=review
> Source/WebCore/rendering/RenderLayer.h:207 > + ChildrenNeedGeometryUpdate = 1 << 10, // This layer's composited children needs a geometry update.
s/needs/need/
> LayoutTests/scrollingcoordinator/reparent-across-compositing-layers.html:14 > + function doTest() {
nit: brace should be on the next line
> LayoutTests/scrollingcoordinator/reparent-with-layer-removal.html:14 > + function doTest() {
Ditto.
Simon Fraser (smfr)
Comment 10
2019-01-23 08:12:56 PST
https://trac.webkit.org/changeset/240336/webkit
Radar WebKit Bug Importer
Comment 11
2019-01-23 08:13:34 PST
<
rdar://problem/47481234
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug