Bug 193699 – Compositing updates need to reparent scrolling tree nodes with a changed ancestor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Compositing updates need to reparent scrolling tree nodes with a changed ancestor

[Simon Fraser (smfr)]

Created attachment 359822 [details]
Patch

[EWS Watchlist]

Comment on attachment 359822 [details]
Patch

Attachment 359822 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10849168

New failing tests:
scrollingcoordinator/reparent-across-compositing-layers.html
scrollingcoordinator/reparent-with-layer-removal.html

[EWS Watchlist]

Created attachment 359831 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 359822 [details]
Patch

Attachment 359822 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10849768

New failing tests:
scrollingcoordinator/reparent-across-compositing-layers.html
scrollingcoordinator/reparent-with-layer-removal.html

[EWS Watchlist]

Created attachment 359841 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 359822 [details]
Patch

Attachment 359822 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10851349

New failing tests:
scrollingcoordinator/reparent-across-compositing-layers.html
scrollingcoordinator/reparent-with-layer-removal.html

[EWS Watchlist]

Created attachment 359852 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Simon Fraser (smfr)]

Created attachment 359854 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 359854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359854&action=review

> Source/WebCore/rendering/RenderLayer.h:207
> +        ChildrenNeedGeometryUpdate                          = 1 << 10, // This layer's composited children needs a geometry update.

s/needs/need/

> LayoutTests/scrollingcoordinator/reparent-across-compositing-layers.html:14
> +        function doTest() {

nit: brace should be on the next line

> LayoutTests/scrollingcoordinator/reparent-with-layer-removal.html:14
> +        function doTest() {

Ditto.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/240336/webkit

[Radar WebKit Bug Importer]

<rdar://problem/47481234>