Bug 193692 - Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results
Summary: Remove an iOS quirk where iframe renderers are identified as "RenderPartObjec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-22 15:51 PST by Simon Fraser (smfr)
Modified: 2019-01-22 16:25 PST (History)
5 users (show)

See Also:


Attachments
Patch (134.68 KB, patch)
2019-01-22 15:52 PST, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-22 15:51:05 PST
Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results
Comment 1 Simon Fraser (smfr) 2019-01-22 15:52:15 PST
Created attachment 359792 [details]
Patch
Comment 2 zalan 2019-01-22 15:53:31 PST
Comment on attachment 359792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359792&action=review

> Source/WebCore/ChangeLog:8
> +		Remove the iOS-specific renderName() implementation.

extra indent?
Comment 3 zalan 2019-01-22 15:54:00 PST
Lol at RenderPart.
Comment 4 EWS Watchlist 2019-01-22 15:54:20 PST
Attachment 359792 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 117 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2019-01-22 16:24:34 PST
https://trac.webkit.org/r240307
Comment 6 Radar WebKit Bug Importer 2019-01-22 16:25:27 PST
<rdar://problem/47464813>