Bug 193689 - [ARM] Check for negative zero instead of just zero
Summary: [ARM] Check for negative zero instead of just zero
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-22 15:13 PST by Dominik Inführ
Modified: 2019-01-29 02:42 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2019-01-22 15:16 PST, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.15 MB, application/zip)
2019-01-22 16:40 PST, EWS Watchlist 		no flags Details
Patch (2.65 KB, patch)
2019-01-23 03:24 PST, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2019-01-22 15:13:34 PST 
[ARM] Check for negative zero instead of just zero
Comment 1 Dominik Inführ 2019-01-22 15:16:55 PST 
Created attachment 359788 [details]
Patch
Comment 2 EWS Watchlist 2019-01-22 16:40:27 PST 
Comment on attachment 359788 [details]
Patch

Attachment 359788 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10846835

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 3 EWS Watchlist 2019-01-22 16:40:28 PST 
Created attachment 359807 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Dominik Inführ 2019-01-23 03:24:54 PST 
Created attachment 359866 [details]
Patch
Comment 5 Mark Lam 2019-01-23 11:49:12 PST 
Comment on attachment 359866 [details]
Patch

r=me.  Is there already a test that verifies that -0 compares work correctly?  I think there probably is, but if you not, can you add one?
Comment 6 Dominik Inführ 2019-01-24 02:31:45 PST 
Hi, thanks for the review! I've thought about writing tests, but there seemed to be enough tests:

JSTests/stress/math-(floor|trunc|round|ceil)-basics.js,  JSTests/stress/op_div_<something> and JSTests/stress/arith-(round|floor|ceil|trunc)-on-various-types.js.
Comment 7 WebKit Commit Bot 2019-01-29 02:41:33 PST 
Comment on attachment 359866 [details]
Patch

Clearing flags on attachment: 359866

Committed r240650: <https://trac.webkit.org/changeset/240650>
Comment 8 WebKit Commit Bot 2019-01-29 02:41:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-01-29 02:42:30 PST 
<rdar://problem/47627879>