Bug 193682 - Adding a child to a ScrollingStateNode needs to trigger a tree state commit
Summary: Adding a child to a ScrollingStateNode needs to trigger a tree state commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-22 13:49 PST by Simon Fraser (smfr)
Modified: 2019-01-23 00:54 PST (History)
11 users (show)

See Also:


Attachments
Patch (16.25 KB, patch)
2019-01-22 13:52 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (16.20 KB, patch)
2019-01-22 14:30 PST, Simon Fraser (smfr)
zalan: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (2.45 MB, application/zip)
2019-01-22 15:12 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews117 for mac-highsierra (1.98 MB, application/zip)
2019-01-22 16:17 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews205 for win-future (12.84 MB, application/zip)
2019-01-22 17:55 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-22 13:49:15 PST
Adding a child to a ScrollingStateNode needs to trigger a tree state commit
Comment 1 Simon Fraser (smfr) 2019-01-22 13:52:02 PST
Created attachment 359771 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-01-22 14:30:24 PST
Created attachment 359774 [details]
Patch
Comment 3 EWS Watchlist 2019-01-22 15:11:50 PST
Comment on attachment 359774 [details]
Patch

Attachment 359774 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10845206

New failing tests:
scrollingcoordinator/lose-scrolling-node-parent.html
scrollingcoordinator/gain-scrolling-node-parent.html
Comment 4 EWS Watchlist 2019-01-22 15:12:00 PST
Created attachment 359784 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 Simon Fraser (smfr) 2019-01-22 15:18:09 PST
Those tests should not run in WK1 (bug 193690).
Comment 6 EWS Watchlist 2019-01-22 16:17:57 PST
Comment on attachment 359774 [details]
Patch

Attachment 359774 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10846000

New failing tests:
scrollingcoordinator/lose-scrolling-node-parent.html
scrollingcoordinator/gain-scrolling-node-parent.html
Comment 7 EWS Watchlist 2019-01-22 16:17:58 PST
Created attachment 359801 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-01-22 17:55:25 PST
Comment on attachment 359774 [details]
Patch

Attachment 359774 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10848279

New failing tests:
scrollingcoordinator/lose-scrolling-node-parent.html
scrollingcoordinator/gain-scrolling-node-parent.html
Comment 9 EWS Watchlist 2019-01-22 17:55:37 PST
Created attachment 359824 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 10 Simon Fraser (smfr) 2019-01-22 21:43:13 PST
https://trac.webkit.org/changeset/240326/webkit
Comment 11 Radar WebKit Bug Importer 2019-01-22 21:44:33 PST
<rdar://problem/47471224>
Comment 12 Frédéric Wang (:fredw) 2019-01-23 00:54:38 PST
Comment on attachment 359774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359774&action=review

> LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html:4
> +    <title>Check that scrolling nodes get reparented when an ancestor is removed</title>

I'm confused by the file name, title and #target going from scroll to visible. I think two last are not what you wanted to do, right?

> LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html:14
> +        function doTest() {

nit: the brace should be on the next line

> LayoutTests/scrollingcoordinator/lose-scrolling-node-parent.html:14
> +        function doTest() {

Ditto.