Bug 193668 - [iOS] Flash when swiping back to Google search result page
Summary: [iOS] Flash when swiping back to Google search result page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-22 06:54 PST by Antti Koivisto
Modified: 2019-01-22 14:31 PST (History)
9 users (show)

See Also:

Attachments
patch (4.33 KB, patch)
2019-01-22 07:15 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.69 MB, application/zip)
2019-01-22 08:08 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-01-22 06:54:30 PST 
If the google page is scrolled, there is sometimes a short flash.
Comment 1 Antti Koivisto 2019-01-22 06:54:51 PST 
<rdar://problem/47071684>
Comment 2 Antti Koivisto 2019-01-22 07:15:04 PST 
Created attachment 359733 [details]
patch
Comment 3 EWS Watchlist 2019-01-22 08:08:18 PST 
Comment on attachment 359733 [details]
patch

Attachment 359733 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10839122

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 4 EWS Watchlist 2019-01-22 08:08:20 PST 
Created attachment 359736 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 5 Geoffrey Garen 2019-01-22 11:39:37 PST 
Comment on attachment 359733 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review

Crash seems unrelated:

  imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html [ Crash ]

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:349
> +            m_hasRestoredExposedContentRectAfterDidCommitLoad = true;

Do we need to set this back to false at some point?
Comment 6 Antti Koivisto 2019-01-22 12:06:35 PST 
Comment on attachment 359733 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5607
> +    m_hasRestoredExposedContentRectAfterDidCommitLoad = false;

Right here.
Comment 7 Geoffrey Garen 2019-01-22 13:01:49 PST 
Comment on attachment 359733 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5607
>> +    m_hasRestoredExposedContentRectAfterDidCommitLoad = false;
> 
> Right here.

LOL, not sure how I missed this.
Comment 8 WebKit Commit Bot 2019-01-22 14:31:43 PST 
Comment on attachment 359733 [details]
patch

Clearing flags on attachment: 359733

Committed r240298: <https://trac.webkit.org/changeset/240298>
Comment 9 WebKit Commit Bot 2019-01-22 14:31:45 PST 
All reviewed patches have been landed.  Closing bug.