Bug 193661 - [JSC] Intl constructors should fit in sizeof(InternalFunction)
Summary: [JSC] Intl constructors should fit in sizeof(InternalFunction)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 193606
  Show dependency treegraph
 
Reported: 2019-01-21 16:18 PST by Yusuke Suzuki
Modified: 2019-01-22 21:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (44.48 KB, patch)
2019-01-21 16:25 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-highsierra (2.52 MB, application/zip)
2019-01-21 17:31 PST, EWS Watchlist
no flags Details
Patch (46.80 KB, patch)
2019-01-21 17:35 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (44.75 KB, patch)
2019-01-21 17:37 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (44.83 KB, patch)
2019-01-21 19:00 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-01-21 16:18:23 PST
[JSC] Intl constructors should fit to sizeof(InternalFunction)
Comment 1 Yusuke Suzuki 2019-01-21 16:25:39 PST
Created attachment 359710 [details]
Patch
Comment 2 Yusuke Suzuki 2019-01-21 16:27:27 PST
Currently, we do not have the good way handling ENABLE(INTL) in our create_hash_table script. But in the future, we can make IntlObject lazily-initialized too.
Comment 3 EWS Watchlist 2019-01-21 17:31:18 PST
Comment on attachment 359710 [details]
Patch

Attachment 359710 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10833541

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2019-01-21 17:31:19 PST
Created attachment 359714 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 Yusuke Suzuki 2019-01-21 17:35:12 PST
Created attachment 359715 [details]
Patch
Comment 6 Yusuke Suzuki 2019-01-21 17:37:15 PST
Created attachment 359716 [details]
Patch
Comment 7 Yusuke Suzuki 2019-01-21 19:00:12 PST
Created attachment 359717 [details]
Patch
Comment 8 Mark Lam 2019-01-22 11:11:05 PST
Comment on attachment 359717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review

r=me

> Source/JavaScriptCore/ChangeLog:14
> +        This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists

typo: /patchh/patch/.
Comment 9 Yusuke Suzuki 2019-01-22 11:16:23 PST
Comment on attachment 359717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review

>> Source/JavaScriptCore/ChangeLog:14
>> +        This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists
> 
> typo: /patchh/patch/.

Nice! Fixed.
Comment 10 Yusuke Suzuki 2019-01-22 12:33:42 PST
Committed r240273: <https://trac.webkit.org/changeset/240273>
Comment 11 Radar WebKit Bug Importer 2019-01-22 12:34:42 PST
<rdar://problem/47455898>
Comment 12 Yusuke Suzuki 2019-01-22 21:59:47 PST
~1% improvement in RAMification.