RESOLVED FIXED193660
REGRESSION (r240243): Caused an API tests to fail 
https://bugs.webkit.org/show_bug.cgi?id=193660
Summary REGRESSION (r240243): Caused an API tests to fail
Brent Fulgham
Reported 2019-01-21 15:50:11 PST
Correct an API test failure introduced by my changes in r240243.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-21 15:50:42 PST
<rdar://problem/47433602>
Brent Fulgham
Comment 2 2019-01-21 17:41:13 PST
My original patch was incrementing the pending callback count before deciding if a callback was actually needed. This left it out of balance, preventing the callback from ever firing.
Brent Fulgham
Comment 3 2019-01-21 17:55:55 PST
Committed r240247: <https://trac.webkit.org/changeset/240247>
Alexey Proskuryakov
Comment 4 2019-01-22 09:29:41 PST
Yay tests!
Brent Fulgham
Comment 5 2019-01-22 09:34:14 PST
(In reply to Alexey Proskuryakov from comment #4) > Yay tests! And for actually paying attention to them! :-)
Michael Catanzaro
Comment 6 2019-01-22 16:32:30 PST
Committed r240308: <https://trac.webkit.org/changeset/240308>
Note You need to log in before you can comment on or make changes to this bug.