Bug 193652 - DoesGC rule is wrong for nodes with BigIntUse
Summary: DoesGC rule is wrong for nodes with BigIntUse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-21 04:50 PST by Caio Lima
Modified: 2019-01-21 15:58 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.84 KB, patch)
2019-01-21 11:58 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Benchmarks (95.75 KB, text/plain)
2019-01-21 12:23 PST, Caio Lima 		no flags Details
Patch (4.80 KB, patch)
2019-01-21 12:30 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2019-01-21 04:50:59 PST 
...
Comment 1 Caio Lima 2019-01-21 11:58:35 PST 
Created attachment 359701 [details]
Patch
Comment 2 Saam Barati 2019-01-21 12:12:02 PST 
Comment on attachment 359701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359701&action=review

r=me

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:388
> +        return node->binaryUseKind() == BigIntUse;

Might as well return true here. Because the clobberize check above, we won’t reach here. However, it’s nicer just to say true IMO
Comment 3 Caio Lima 2019-01-21 12:23:31 PST 
Created attachment 359704 [details]
Benchmarks

Patch seems to be perf neutral on macOS x86_64.
Comment 4 Caio Lima 2019-01-21 12:28:57 PST 
Comment on attachment 359701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359701&action=review

Thank you for the review!

>> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:388
>> +        return node->binaryUseKind() == BigIntUse;
> 
> Might as well return true here. Because the clobberize check above, we won’t reach here. However, it’s nicer just to say true IMO

Makes sense. Changed.
Comment 5 Caio Lima 2019-01-21 12:30:59 PST 
Created attachment 359705 [details]
Patch
Comment 6 WebKit Commit Bot 2019-01-21 15:57:31 PST 
Comment on attachment 359705 [details]
Patch

Clearing flags on attachment: 359705

Committed r240244: <https://trac.webkit.org/changeset/240244>
Comment 7 WebKit Commit Bot 2019-01-21 15:57:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-01-21 15:58:28 PST 
<rdar://problem/47433654>