Bug 193644 - DFG: When inlining DataView set* intrinsics we need to set undefined as our result
Summary: DFG: When inlining DataView set* intrinsics we need to set undefined as our r...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
Keywords: InRadar
Depends on:
Reported: 2019-01-20 20:12 PST by Saam Barati
Modified: 2019-01-20 22:13 PST (History)
14 users (show)

See Also:

patch (102.22 KB, patch)
2019-01-20 20:39 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-01-20 20:12:51 PST
Comment 1 Saam Barati 2019-01-20 20:14:24 PST
Comment 2 Saam Barati 2019-01-20 20:39:47 PST
Created attachment 359668 [details]
Comment 3 EWS Watchlist 2019-01-20 20:41:13 PST
Attachment 359668 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2144:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2185:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2019-01-20 21:19:42 PST
Comment on attachment 359668 [details]

Comment 5 WebKit Commit Bot 2019-01-20 22:13:14 PST
Comment on attachment 359668 [details]

Clearing flags on attachment: 359668

Committed r240229: <https://trac.webkit.org/changeset/240229>
Comment 6 WebKit Commit Bot 2019-01-20 22:13:15 PST
All reviewed patches have been landed.  Closing bug.