Bug 193633 - Need cross-platform implementation of TestController::allowCacheStorageQuotaIncrease
Summary: Need cross-platform implementation of TestController::allowCacheStorageQuotaI...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-20 15:07 PST by Michael Catanzaro
Modified: 2019-02-01 09:27 PST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-01-20 15:07:18 PST
Layout test http/wpt/cache-storage/cache-quota.any.html has been failing for GTK since r240156 "Add a new SPI to request for cache storage quota increase":

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/wpt/cache-storage/cache-quota.any-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/wpt/cache-storage/cache-quota.any-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 
@@ -5,5 +6,5 @@
 PASS Testing non opaque response body size padding 
 PASS Testing opaque response body size padding 
 PASS Hitting cache quota for non opaque responses 
-PASS Hitting cache quota for padded responses 
+FAIL Hitting cache quota for padded responses promise_test: Unhandled rejection with value: object "QuotaExceededError: Quota exceeded"
 
We need to add a cross-platform implementation of TestController::allowCacheStorageQuotaIncrease using a new C API.
Comment 1 Shawn Roberts 2019-02-01 09:27:51 PST
Is also a flaky failure and time out on MacOS and iOS 12 Simulator

Reproducable with:

run-webkit-tests t240848 http/wpt/cache-storage/cache-quota.any.html --iterations 500 -f

Flakiness Dashboard: 

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fcache-storage%2Fcache-quota.any.html

diff: 

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota.any-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/cache-quota.any-actual.txt
@@ -1,9 +1,9 @@
-CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
+CONSOLE MESSAGE: Cache API operation failed: Failed writing data to the file system
 CONSOLE MESSAGE: Cache API operation failed: Quota exceeded
 
 PASS Testing synthetic response body size padding 
 PASS Testing non opaque response body size padding 
 PASS Testing opaque response body size padding 
-PASS Hitting cache quota for non opaque responses 
+FAIL Hitting cache quota for non opaque responses promise_test: Unhandled rejection with value: object "TypeError: Failed writing data to the file system"
 PASS Hitting cache quota for padded responses