Bug 193630 – REGRESSION(r240174): Wrong preprocessor guards in RenderImage::paintAreaElementFocusRing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Michael Catanzaro]

Layout test fast/images/image-map-outline-in-positioned-container.html is failing for GTK since r240174 "CSS auto focus-ring outlines don't render on iOS". The autofocus is no longer rendered:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r240208%20(9437)/fast/images/image-map-outline-in-positioned-container-diffs.html

I think the problem is in RenderImage::paintAreaElementFocusRing. Here some code that used to be cross-platform was changed to be Cocoa-specific by moving it inside the Cocoa-specific ENABLE(FULL_KEYBOARD_ACCESS) guard. I'm not sure what the right guard would be here, but perhaps !PLATFORM(IOS_FAMILY) || ENABLE(FULL_KEYBOARD_ACCESS) would do the trick.

[Michael Catanzaro]

Note: I'm adding a failure expectation for this test, which should be removed when fixed.

[Daniel Bates]

(In reply to Michael Catanzaro from comment #0)
> Layout test fast/images/image-map-outline-in-positioned-container.html is
> failing for GTK since r240174 "CSS auto focus-ring outlines don't render on
> iOS". The autofocus is no longer rendered:
> 
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r240208%20(9437)/fast/images/image-map-outline-in-positioned-container-diffs.
> html
> 
> I think the problem is in RenderImage::paintAreaElementFocusRing. 

Yes, there is a problem here. Oops! Shouldn't have tried to do two things at once: inverting the if-else and get this code working for PLATFORM(IOS_FAMILY) && ENABLE(FULL_KEYBOARD_ACCESS).


> Here some
> code that used to be cross-platform was changed to be Cocoa-specific by
> moving it inside the Cocoa-specific ENABLE(FULL_KEYBOARD_ACCESS) guard. I'm
> not sure what the right guard would be here, but perhaps
> !PLATFORM(IOS_FAMILY) || ENABLE(FULL_KEYBOARD_ACCESS) would do the trick.

Yes, that would fix it! I am not near a computer with a checkout. If you can fix I would appreciate it.

[Michael Catanzaro]

OK!

[Daniel Bates]

(In reply to Michael Catanzaro from comment #3)
> OK!

Thank you, Michael!

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #1)
> Note: I'm adding a failure expectation for this test, which should be
> removed when fixed.

I didn't actually commit the expectation yet, so nevermind that.

[Michael Catanzaro]

Created attachment 359663 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 359663 [details]
Patch

Clearing flags on attachment: 359663

Committed r240221: <https://trac.webkit.org/changeset/240221>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47419540>

[Miguel Gomez]

This made fast/images/image-map-outline-in-positioned-container.html to properly pass, so updating expectation.