Bug 19363 - Compiler error in Entity.h
Summary: Compiler error in Entity.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Major
Assignee: Nobody
Depends on:
Reported: 2008-06-02 15:34 PDT by Alexander Vassilev
Modified: 2008-06-03 00:57 PDT (History)
0 users

See Also:

proposed temporary fix (552 bytes, patch)
2008-06-02 15:36 PDT, Alexander Vassilev
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Vassilev 2008-06-02 15:34:31 PDT
Compiling WebKit with MINGW, cygwin environment.
Compiler says that class Entity has a default constructor but its base class ContainerNode doesn't have a default constructor. From what I found the Entity class is there only for compatibility, so I made a temporary fix with teh attached patch, but I hope someone competent can solve the problem the right way.
Comment 1 Alexander Vassilev 2008-06-02 15:36:24 PDT
Created attachment 21470 [details]
proposed temporary fix
Comment 2 Alexey Proskuryakov 2008-06-03 00:56:51 PDT
Comment on attachment 21470 [details]
proposed temporary fix

I think that this is basically the right fix. I'll land it with some modifications.

+    Entity(): ContainerNode(0){};

We'd write this as

+    Entity() : ContainerNode(0) {}

Also, the constructor should be private for clarity.
Comment 3 Alexey Proskuryakov 2008-06-03 00:57:59 PDT
Fixed in <http://trac.webkit.org/changeset/34336>.