Bug 19362 - JSProfiler: function highlighting, highlights the opening bracket of the function, not its name.
Summary: JSProfiler: function highlighting, highlights the opening bracket of the func...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-06-02 13:48 PDT by Kevin McCullough
Modified: 2014-12-12 14:08 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McCullough 2008-06-02 13:48:54 PDT 
* SUMMARY
In the Profiler in the Web Inspector you can click on the url and line number of a function profiled and it will open the resource and take you to that line number and highlight the line number.  However it goes to the line of the opening brace, the '{', and if that is on a different line than the function name then it can be confusing and isn't exactly what we wanted.

e.g.

function foo()
{
   dosomething();
}

vs

function foo () {
  dosomething();
}

* STEPS TO REPRODUCE
1. Load WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html into Safari
2. Open the profiler and expand all of the functions.
3. Click the url next to 'IntermediaryFunction' and notice the highlighted line is just a '{'
4. Go back to the profiler and click 'InsertNewText' and notice it highlights the function name.

<rdar://problem/5979901>
Comment 1 Brian Burg 2014-12-12 14:08:56 PST 
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.