Bug 193613 - [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
Summary: [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always hori...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-19 07:38 PST by zalan
Modified: 2019-01-19 21:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.78 KB, patch)
2019-01-19 07:47 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-19 07:38:54 PST 
Usually they are in order, expect with negative margins.
Comment 1 zalan 2019-01-19 07:47:16 PST 
Created attachment 359610 [details]
Patch
Comment 2 Antti Koivisto 2019-01-19 09:52:18 PST 
Comment on attachment 359610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359610&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:101
> +        if (isLeftPositioned^floatItem.isLeftPositioned())

!= ?
Comment 3 zalan 2019-01-19 21:26:46 PST 
Committed r240207: <https://trac.webkit.org/changeset/240207>
Comment 4 Radar WebKit Bug Importer 2019-01-19 21:27:28 PST 
<rdar://problem/47412748>