Bug 193607 – C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated in each source file that includes this header:

$ egrep -l -r 'ClientCertificateAuthenticationXPCConstants.h[">]' Source/WebKit 
Source/WebKit/UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm
Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm

We should move the string constants to their own source file so they aren't duplicated.

[David Kilzer (:ddkilzer)]

<rdar://problem/47334613>

[David Kilzer (:ddkilzer)]

Created attachment 359585 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Created attachment 359588 [details]
Patch v2

[David Kilzer (:ddkilzer)]

Created attachment 359612 [details]
Patch v3

[Alex Christensen]

Comment on attachment 359612 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=359612&action=review

> Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h:32
> +struct ClientCertificateAuthentication {

Isn't this more of a namespace?

[David Kilzer (:ddkilzer)]

Comment on attachment 359612 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=359612&action=review

>> Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h:32
>> +struct ClientCertificateAuthentication {
> 
> Isn't this more of a namespace?

Sure, a namespace could be used instead.  Would you prefer that?

[David Kilzer (:ddkilzer)]

Created attachment 359706 [details]
Patch v4 (for landing)

[David Kilzer (:ddkilzer)]

Comment on attachment 359706 [details]
Patch v4 (for landing)

Now with namespace.

[David Kilzer (:ddkilzer)]

Committed r240275: <https://trac.webkit.org/changeset/240275>