RESOLVED FIXED 193595
[build.webkit.org] api tests failures are incorrectly named as unit test failures 
https://bugs.webkit.org/show_bug.cgi?id=193595
Summary [build.webkit.org] api tests failures are incorrectly named as unit test fail...
Aakash Jain
Reported 2019-01-18 15:13:50 PST
api tests failures are incorrectly named as unit test failures by build.webkit.org e.g.: https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/1759/steps/run-api-tests says: "2 unit tests failed or timed out", However these are not unit tests, these are api tests. We should fix the build.webkit.org configuration to name it api tests instead of unit tests.
Attachments
Proposed patch (3.86 KB, patch)
2019-01-18 15:22 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-18 15:22:18 PST
Created attachment 359547 [details] Proposed patch The original patch to add api test to build.webkit.org configuration named it unit tests: https://trac.webkit.org/changeset/89054/webkit
EWS Watchlist
Comment 2 2019-01-18 15:24:11 PST
Attachment 359547 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:276: [RunAPITestsTest.assertFailures] Undefined variable 'RunAPITests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:93: [TestFactory.__init__] Undefined variable 'RunAPITests' [pylint/E0602] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 3 2019-01-18 15:37:49 PST
lgtm, assuming the style errors are false.
WebKit Commit Bot
Comment 4 2019-01-18 16:10:24 PST
Comment on attachment 359547 [details] Proposed patch Clearing flags on attachment: 359547 Committed r240187: <https://trac.webkit.org/changeset/240187>
WebKit Commit Bot
Comment 5 2019-01-18 16:10:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-18 16:11:29 PST
<rdar://problem/47400323>
Daniel Bates
Comment 7 2019-01-18 16:53:25 PST
po-tay-to po-tah-to run-api-tests is a misnomer. It has long since outgrown itself from its humble beginnings of being used to test WebKit API/SPI. It now runs WTF tests and WebCore tests. We typically use the term "API" to refer to the public interfaces that are available to customers. I would argue that "unit tests" is probably more accurate for what run-api-tests does. Oh well...
Note You need to log in before you can comment on or make changes to this bug.