WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193586
Revert
r238815
, it broke WK1 video fullscreen on Mac
https://bugs.webkit.org/show_bug.cgi?id=193586
Summary
Revert r238815, it broke WK1 video fullscreen on Mac
Eric Carlson
Reported
2019-01-18 12:25:56 PST
Revert
r238815
, it broke WK1 video fullscreen on Mac
Attachments
Patch
(62.45 KB, patch)
2019-01-18 13:49 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Patch
(77.60 KB, patch)
2019-01-18 14:09 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Rabased patch for landing
(62.37 KB, patch)
2019-01-18 15:55 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2019-01-18 12:26:37 PST
<
rdar://problem/47358941
>
Eric Carlson
Comment 2
2019-01-18 13:49:48 PST
Created
attachment 359534
[details]
Patch
EWS Watchlist
Comment 3
2019-01-18 13:51:41 PST
Attachment 359534
[details]
did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm:494: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4
2019-01-18 14:09:49 PST
Created
attachment 359538
[details]
Patch
EWS Watchlist
Comment 5
2019-01-18 14:11:21 PST
Attachment 359538
[details]
did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm:493: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6
2019-01-18 15:10:38 PST
Comment on
attachment 359538
[details]
Patch Rejecting
attachment 359538
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 359538, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=359538&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=193586
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 359538 from
bug 193586
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=359538
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 12 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/ChangeLog patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/PlatformMac.cmake patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj Hunk #1 FAILED at 6430. Hunk #2 succeeded at 17129 with fuzz 2 (offset 92 lines). Hunk #3 FAILED at 25700. Hunk #4 succeeded at 32442 (offset 1 line). 2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp patching file Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.h patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm Hunk #2 succeeded at 9380 (offset -8 lines). Hunk #3 succeeded at 9397 (offset -8 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 12 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/ChangeLog patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/PlatformMac.cmake patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj Hunk #1 FAILED at 6430. Hunk #2 succeeded at 17129 with fuzz 2 (offset 92 lines). Hunk #3 FAILED at 25700. Hunk #4 succeeded at 32442 (offset 1 line). 2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp patching file Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.h patching file Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm Hunk #2 succeeded at 9380 (offset -8 lines). Hunk #3 succeeded at 9397 (offset -8 lines). Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From
https://git.webkit.org/git/WebKit
c789475f06c..35847c83606 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 240176 = c789475f06cb430583a98f69cc13a9d31270167b
r240177
= ab48d3a26378bbfd9e1bf8de74c60fe677dd337a
r240178
= 65645bd5f618f808f74aec667599066053d37a83
r240179
= c1b35a255f327430a28782c20d81314f6961a24e
r240180
= 35847c836067053837f23b5101da6bcee46f5abd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output:
https://webkit-queues.webkit.org/results/10802040
Eric Carlson
Comment 7
2019-01-18 15:55:48 PST
Created
attachment 359550
[details]
Rabased patch for landing
EWS Watchlist
Comment 8
2019-01-18 15:58:01 PST
Attachment 359550
[details]
did not pass style-queue: ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm:493: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 9
2019-01-18 16:22:48 PST
Comment on
attachment 359550
[details]
Rabased patch for landing Clearing flags on attachment: 359550 Committed
r240190
: <
https://trac.webkit.org/changeset/240190
>
WebKit Commit Bot
Comment 10
2019-01-18 16:22:51 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug