Bug 193564 – [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 359451 [details]
Patch

[Antti Koivisto]

Comment on attachment 359451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359451&action=review

> LayoutTests/fast/block/float/float-in-descendant-formatting-context-expected.txt:9
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x26
> +  RenderBlock {HTML} at (0,0) size 800x26
> +    RenderBody {BODY} at (8,8) size 784x10
> +layer at (8,8) size 784x10
> +  RenderBlock {DIV} at (0,0) size 784x10
> +    RenderInline {SPAN} at (0,0) size 0x0
> +    RenderBlock (floating) {DIV} at (0,0) size 10x10

Could we do ref tests instead? Render tree dumps are bit weird for testing something that ultimately won't have render tree.

[zalan]

Committed r240146: <https://trac.webkit.org/changeset/240146>

[Radar WebKit Bug Importer]

<rdar://problem/47383635>

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 359451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359451&action=review
> 
> > LayoutTests/fast/block/float/float-in-descendant-formatting-context-expected.txt:9
> > +layer at (0,0) size 800x600
> > +  RenderView at (0,0) size 800x600
> > +layer at (0,0) size 800x26
> > +  RenderBlock {HTML} at (0,0) size 800x26
> > +    RenderBody {BODY} at (8,8) size 784x10
> > +layer at (8,8) size 784x10
> > +  RenderBlock {DIV} at (0,0) size 784x10
> > +    RenderInline {SPAN} at (0,0) size 0x0
> > +    RenderBlock (floating) {DIV} at (0,0) size 10x10
> 
> Could we do ref tests instead? Render tree dumps are bit weird for testing
> something that ultimately won't have render tree.
In certain cases when testing against geometry it is actually more reliable to dump the box geometry and match against that (especially at this phase of the project and with this type of content). However I agree that the dumps in this format are not optimal/future-proof. That we should definitely change.