Analyzing a chart that does not exist should not halt whole run-analysis script.
Created attachment 359449 [details] Patch
Comment on attachment 359449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359449&action=review > Websites/perf.webkit.org/ChangeLog:17 > + (async.set requests): > + (async): Remove these? > Websites/perf.webkit.org/tools/js/measurement-set-analyzer.js:55 > + } catch (error) { > + this._logger.warn(`Skipping analysis for "${metric.fullName()}" on "${platform.name()}" as time series does not exit.`); Please check/assert for a specific error instead of swallowing any exception.
Created attachment 359598 [details] Patch
Comment on attachment 359598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359598&action=review > Websites/perf.webkit.org/public/v3/models/measurement-set.js:86 > + if (promise && callback) { > promise.then(callback, callback); > - else { > + } else if (!promise) { It would be cleaner to nest if's as in: if (promise) { if (callback) ~ } else { ~ }
Landed in r240319.