Bug 193562 - [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
Summary: [LFC] Do not skip float boxes that are not part of the current formatting con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-17 21:49 PST by zalan
Modified: 2019-01-18 06:41 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2019-01-17 22:00 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-highsierra (1.98 MB, application/zip)
2019-01-17 23:46 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-17 21:49:42 PST 
When computing the bottom value (height computation) the current floating context's (float) boxes could belong to descendant formatting contexts. Include them as well while computing bottom.
see ->
<div style="overflow: hidden"><div>foo<div style="float: left">bar</div></div></div>
Comment 1 zalan 2019-01-17 22:00:17 PST 
Created attachment 359447 [details]
Patch
Comment 2 EWS Watchlist 2019-01-17 23:46:00 PST 
Comment on attachment 359447 [details]
Patch

Attachment 359447 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10792709

New failing tests:
compositing/backing/animate-into-view.html
Comment 3 EWS Watchlist 2019-01-17 23:46:01 PST 
Created attachment 359454 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 zalan 2019-01-18 06:40:05 PST 
Committed r240145: <https://trac.webkit.org/changeset/240145>
Comment 5 Radar WebKit Bug Importer 2019-01-18 06:41:28 PST 
<rdar://problem/47383591>