Bug 193554 – A track source should be unmuted whenever reenabled after setDirection changes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

A track source should be unmuted whenever reenabled after setDirection changes

[Radar WebKit Bug Importer]

<rdar://problem/47366196>

[youenn fablet]

Created attachment 359426 [details]
Patch

[Eric Carlson]

Comment on attachment 359426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359426&action=review

> LayoutTests/webrtc/video-setDirection.html:100
> +        assert_equals(stream, video.srcObject);

Why does this fail?

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 359426 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359426&action=review
> 
> > LayoutTests/webrtc/video-setDirection.html:100
> > +        assert_equals(stream, video.srcObject);
> 
> Why does this fail?

Libwebrtc tell us that the media stream is gone (through OnRemoveStream) so we remove it and recreate it later on.

We should probably keep a weak of the MediaStream instead.
If still there, we could then reuse it.
Otherwise, recreating a new one would be unobservable.

[WebKit Commit Bot]

Comment on attachment 359426 [details]
Patch

Clearing flags on attachment: 359426

Committed r240152: <https://trac.webkit.org/changeset/240152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.