If bug_id is None for any reason (e.g.: EWS web-app did not passed bug_id to buildbot), it should be handled properly. Note that EWS doesn't need bug_id to process the patch, it is needed only to validate if the bug is still open or already closed.
Created attachment 359403 [details] Proposed patch
Comment on attachment 359403 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review r=me with typo fix. > Tools/ChangeLog:10 > + (ValidatePatch.start): If bug_id is set as None in build propeties, fetch it from the patch. typo: properties
Comment on attachment 359403 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:334 > + bug_id = self.getProperty('bug_id', '') or self.get_bug_id_from_patch(patch_id) Is self.get_bug_id_from_patch(patch_id) a network operation? That's the only reason I can think to change this.
> Is self.get_bug_id_from_patch(patch_id) a network operation? Yes, it is a network operation. It fetches the patch using bugzilla REST API and reads bug id from it.
Committed r240128: <https://trac.webkit.org/changeset/240128>
<rdar://problem/47362136>