RESOLVED FIXED 193547
[ews-build] validate-patch should handle the case when bug_id is None 
https://bugs.webkit.org/show_bug.cgi?id=193547
Summary [ews-build] validate-patch should handle the case when bug_id is None
Aakash Jain
Reported 2019-01-17 12:11:33 PST
If bug_id is None for any reason (e.g.: EWS web-app did not passed bug_id to buildbot), it should be handled properly. Note that EWS doesn't need bug_id to process the patch, it is needed only to validate if the bug is still open or already closed.
Attachments
Proposed patch (1.82 KB, patch)
2019-01-17 12:17 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-17 12:17:20 PST
Created attachment 359403 [details] Proposed patch
Lucas Forschler
Comment 2 2019-01-17 12:57:32 PST
Comment on attachment 359403 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review r=me with typo fix. > Tools/ChangeLog:10 > + (ValidatePatch.start): If bug_id is set as None in build propeties, fetch it from the patch. typo: properties
Jonathan Bedard
Comment 3 2019-01-17 13:03:17 PST
Comment on attachment 359403 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:334 > + bug_id = self.getProperty('bug_id', '') or self.get_bug_id_from_patch(patch_id) Is self.get_bug_id_from_patch(patch_id) a network operation? That's the only reason I can think to change this.
Aakash Jain
Comment 4 2019-01-17 13:13:13 PST
> Is self.get_bug_id_from_patch(patch_id) a network operation? Yes, it is a network operation. It fetches the patch using bugzilla REST API and reads bug id from it.
Aakash Jain
Comment 5 2019-01-17 13:28:48 PST
Committed r240128: <https://trac.webkit.org/changeset/240128>
Radar WebKit Bug Importer
Comment 6 2019-01-17 13:29:28 PST
<rdar://problem/47362136>
Note You need to log in before you can comment on or make changes to this bug.