Bug 193537 - webkitpy: Add iPhone and iPad ports
Summary: webkitpy: Add iPhone and iPad ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on: 192162
Blocks:
  Show dependency tree / graph
 
Reported: 2019-01-17 09:34 PST by Jonathan Bedard
Modified: 2019-01-18 12:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2019-01-18 08:51 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (8.54 KB, patch)
2019-01-18 11:05 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-01-17 09:34:12 PST 
In addition to the --ios-simualtor port, we should have a --iphone-simulator and --ipad-simulator port. Note that we don't need a --ipad-device and --iphone-device since after the work in <https://bugs.webkit.org/show_bug.cgi?id=192162>, those ports are implicit in which devices are attached.
Comment 1 Radar WebKit Bug Importer 2019-01-17 09:35:32 PST 
<rdar://problem/47353390>
Comment 2 Jonathan Bedard 2019-01-18 08:51:55 PST 
Created attachment 359496 [details]
Patch
Comment 3 Jonathan Bedard 2019-01-18 11:05:37 PST 
Created attachment 359511 [details]
Patch
Comment 4 Aakash Jain 2019-01-18 11:11:21 PST 
Comment on attachment 359511 [details]
Patch

rs=me
Comment 5 Jonathan Bedard 2019-01-18 11:38:23 PST 
Note that this patch (deliberately) does not contain any gardening for the iPad port. I plan on using the bots to help with that task.
Comment 6 WebKit Commit Bot 2019-01-18 12:12:43 PST 
Comment on attachment 359511 [details]
Patch

Clearing flags on attachment: 359511

Committed r240163: <https://trac.webkit.org/changeset/240163>
Comment 7 WebKit Commit Bot 2019-01-18 12:12:45 PST 
All reviewed patches have been landed.  Closing bug.