RESOLVED FIXED Bug 193537
webkitpy: Add iPhone and iPad ports 
https://bugs.webkit.org/show_bug.cgi?id=193537
Summary webkitpy: Add iPhone and iPad ports
Jonathan Bedard
Reported 2019-01-17 09:34:12 PST
In addition to the --ios-simualtor port, we should have a --iphone-simulator and --ipad-simulator port. Note that we don't need a --ipad-device and --iphone-device since after the work in <https://bugs.webkit.org/show_bug.cgi?id=192162>, those ports are implicit in which devices are attached.
Attachments
Patch (1.59 KB, patch)
2019-01-18 08:51 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.54 KB, patch)
2019-01-18 11:05 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-17 09:35:32 PST
<rdar://problem/47353390>
Jonathan Bedard
Comment 2 2019-01-18 08:51:55 PST
Created attachment 359496 [details] Patch
Jonathan Bedard
Comment 3 2019-01-18 11:05:37 PST
Created attachment 359511 [details] Patch
Aakash Jain
Comment 4 2019-01-18 11:11:21 PST
Comment on attachment 359511 [details] Patch rs=me
Jonathan Bedard
Comment 5 2019-01-18 11:38:23 PST
Note that this patch (deliberately) does not contain any gardening for the iPad port. I plan on using the bots to help with that task.
WebKit Commit Bot
Comment 6 2019-01-18 12:12:43 PST
Comment on attachment 359511 [details] Patch Clearing flags on attachment: 359511 Committed r240163: <https://trac.webkit.org/changeset/240163>
WebKit Commit Bot
Comment 7 2019-01-18 12:12:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.