RESOLVED FIXED Bug 193529
Stop using NetworkStorageSession::storageSession in WebCore 
https://bugs.webkit.org/show_bug.cgi?id=193529
Summary Stop using NetworkStorageSession::storageSession in WebCore
Alex Christensen
Reported 2019-01-16 22:56:08 PST
Stop using NetworkStorageSession::storageSession in WebCore
Attachments
Patch (57.45 KB, patch)
2019-01-16 23:00 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (55.79 KB, patch)
2019-01-16 23:13 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (72.02 KB, patch)
2019-01-16 23:25 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (74.85 KB, patch)
2019-01-16 23:41 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (59.15 KB, patch)
2019-01-16 23:49 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.79 KB, patch)
2019-01-16 23:58 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.10 KB, patch)
2019-01-17 00:18 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.18 KB, patch)
2019-01-17 00:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.19 KB, patch)
2019-01-17 09:01 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-16 23:00:04 PST
Created attachment 359352 [details] Patch
Alex Christensen
Comment 2 2019-01-16 23:13:57 PST
Created attachment 359353 [details] patch
Alex Christensen
Comment 3 2019-01-16 23:25:38 PST
Created attachment 359355 [details] Patch
Alex Christensen
Comment 4 2019-01-16 23:41:32 PST
Created attachment 359356 [details] Patch
Alex Christensen
Comment 5 2019-01-16 23:49:09 PST
Created attachment 359357 [details] patch
Alex Christensen
Comment 6 2019-01-16 23:58:10 PST
Created attachment 359358 [details] Patch
Alex Christensen
Comment 7 2019-01-17 00:03:21 PST
The linux build failure looks unrelated, but EWS indicates this patch causes it. Could someone get this building on Linux?
Alex Christensen
Comment 8 2019-01-17 00:18:00 PST
Created attachment 359360 [details] Patch
Alex Christensen
Comment 9 2019-01-17 00:28:50 PST
Created attachment 359361 [details] Patch
Alex Christensen
Comment 10 2019-01-17 09:01:16 PST
Created attachment 359382 [details] Patch
Tim Horton
Comment 11 2019-01-17 11:05:00 PST
Comment on attachment 359382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359382&action=review > Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:1 > + This seems bad. > Source/WebCore/platform/network/soup/SocketStreamHandleImpl.h:1 > + gg
Alex Christensen
Comment 12 2019-01-17 11:11:08 PST
http://trac.webkit.org/r240117
Radar WebKit Bug Importer
Comment 13 2019-01-17 11:12:29 PST
<rdar://problem/47357253>
Alex Christensen
Comment 14 2019-01-17 11:33:14 PST
http://trac.webkit.org/r240121
Note You need to log in before you can comment on or make changes to this bug.