Bug 193529 - Stop using NetworkStorageSession::storageSession in WebCore
Summary: Stop using NetworkStorageSession::storageSession in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-16 22:56 PST by Alex Christensen
Modified: 2019-01-17 11:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (57.45 KB, patch)
2019-01-16 23:00 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (55.79 KB, patch)
2019-01-16 23:13 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (72.02 KB, patch)
2019-01-16 23:25 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (74.85 KB, patch)
2019-01-16 23:41 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (59.15 KB, patch)
2019-01-16 23:49 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.79 KB, patch)
2019-01-16 23:58 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.10 KB, patch)
2019-01-17 00:18 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.18 KB, patch)
2019-01-17 00:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.19 KB, patch)
2019-01-17 09:01 PST, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-01-16 22:56:08 PST 
Stop using NetworkStorageSession::storageSession in WebCore
Comment 1 Alex Christensen 2019-01-16 23:00:04 PST 
Created attachment 359352 [details]
Patch
Comment 2 Alex Christensen 2019-01-16 23:13:57 PST 
Created attachment 359353 [details]
patch
Comment 3 Alex Christensen 2019-01-16 23:25:38 PST 
Created attachment 359355 [details]
Patch
Comment 4 Alex Christensen 2019-01-16 23:41:32 PST 
Created attachment 359356 [details]
Patch
Comment 5 Alex Christensen 2019-01-16 23:49:09 PST 
Created attachment 359357 [details]
patch
Comment 6 Alex Christensen 2019-01-16 23:58:10 PST 
Created attachment 359358 [details]
Patch
Comment 7 Alex Christensen 2019-01-17 00:03:21 PST 
The linux build failure looks unrelated, but EWS indicates this patch causes it.  Could someone get this building on Linux?
Comment 8 Alex Christensen 2019-01-17 00:18:00 PST 
Created attachment 359360 [details]
Patch
Comment 9 Alex Christensen 2019-01-17 00:28:50 PST 
Created attachment 359361 [details]
Patch
Comment 10 Alex Christensen 2019-01-17 09:01:16 PST 
Created attachment 359382 [details]
Patch
Comment 11 Tim Horton 2019-01-17 11:05:00 PST 
Comment on attachment 359382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359382&action=review

> Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:1
> +

This seems bad.

> Source/WebCore/platform/network/soup/SocketStreamHandleImpl.h:1
> +

gg
Comment 12 Alex Christensen 2019-01-17 11:11:08 PST 
http://trac.webkit.org/r240117
Comment 13 Radar WebKit Bug Importer 2019-01-17 11:12:29 PST 
<rdar://problem/47357253>
Comment 14 Alex Christensen 2019-01-17 11:33:14 PST 
http://trac.webkit.org/r240121