Bug 193522 – (iPad) Link tapping is sluggish on many sites

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

(iPad) Link tapping is sluggish on many sites

[Dean Jackson]

<rdar://problem/47102987>

[Dean Jackson]

Created attachment 359340 [details]
Patch

[Wenson Hsieh]

Comment on attachment 359340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359340&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2471
> +    // return !areEssentiallyEqualAsFloat(contentZoomScale(self), 1);

Did you mean to remove this old commented-out line?

> LayoutTests/fast/events/ios/fast-click-double-tap-sends-click-when-initial-scale.html:17
> +            if (!window.UIHelper)

(Ditto)

> LayoutTests/fast/events/ios/viewport-zooms-from-element-to-initial-scale.html:15
> +            if (!window.UIHelper)

Nit - doesn't window.UIHelper exist even in the case where the user is manually testing? It seems like we do want to check either eventSender or runUIScript (or both).

> LayoutTests/resources/ui-helper.js:57
> +    static zoomByDoubleTapAt(x, y)

Nit - zoomByDoubleTappingAt?

[Dean Jackson]

Comment on attachment 359340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359340&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2471
>> +    // return !areEssentiallyEqualAsFloat(contentZoomScale(self), 1);
> 
> Did you mean to remove this old commented-out line?

OOPS!

>> LayoutTests/fast/events/ios/viewport-zooms-from-element-to-initial-scale.html:15
>> +            if (!window.UIHelper)
> 
> Nit - doesn't window.UIHelper exist even in the case where the user is manually testing? It seems like we do want to check either eventSender or runUIScript (or both).

Does it? It shouldn't exist in Safari.

> window.UIHelper
undefined

[Wenson Hsieh]

(In reply to Dean Jackson from comment #4)
> Comment on attachment 359340 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359340&action=review
> 
> >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2471
> >> +    // return !areEssentiallyEqualAsFloat(contentZoomScale(self), 1);
> > 
> > Did you mean to remove this old commented-out line?
> 
> OOPS!
> 
> >> LayoutTests/fast/events/ios/viewport-zooms-from-element-to-initial-scale.html:15
> >> +            if (!window.UIHelper)
> > 
> > Nit - doesn't window.UIHelper exist even in the case where the user is manually testing? It seems like we do want to check either eventSender or runUIScript (or both).
> 
> Does it? It shouldn't exist in Safari.

UIHelper is just a JavaScript class defined in ui-helper.js though. When you tried it in Safari, did you upload all of LayoutTests, or just viewport-zooms-from-element-to-initial-scale.html?

> 
> > window.UIHelper
> undefined

[Dean Jackson]

Comment on attachment 359340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359340&action=review

>>> LayoutTests/fast/events/ios/viewport-zooms-from-element-to-initial-scale.html:15
>>> +            if (!window.UIHelper)
>> 
>> Nit - doesn't window.UIHelper exist even in the case where the user is manually testing? It seems like we do want to check either eventSender or runUIScript (or both).
> 
> Does it? It shouldn't exist in Safari.

Errr.... ignore the incredible stupidness here.

[Dean Jackson]

Committed r240119: <https://trac.webkit.org/changeset/240119>