RESOLVED FIXED 193520
[LFC][BFC] For height computation, the bottom edge of the last line box value should not include top border/padding 
https://bugs.webkit.org/show_bug.cgi?id=193520
Summary [LFC][BFC] For height computation, the bottom edge of the last line box value...
zalan
Reported 2019-01-16 16:34:01 PST
it needs to be in the coordinate system of the containing block's content box.
Attachments
Patch (3.46 KB, patch)
2019-01-16 16:40 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-01-16 16:40:36 PST
Created attachment 359334 [details] Patch
Aakash Jain
Comment 2 2019-01-17 04:55:20 PST
This patch seems to break an API test: TestWebKitAPI.WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton Can you please have a look? Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 We are doing test-runs for upcoming 'EWS for API tests'. If this is a false positive, please let us know.
zalan
Comment 3 2019-01-17 06:44:22 PST
(In reply to Aakash Jain from comment #2) > This patch seems to break an API test: > TestWebKitAPI.WKWebViewAutofillTests. > UsernameAndPasswordFieldSeparatedByRadioButton > > Can you please have a look? > > Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 > > We are doing test-runs for upcoming 'EWS for API tests'. If this is a false > positive, please let us know. Sure but this code is behind a run time flag and the flag is not enabled.
Wenson Hsieh
Comment 4 2019-01-17 07:13:11 PST
(In reply to Aakash Jain from comment #2) > This patch seems to break an API test: > TestWebKitAPI.WKWebViewAutofillTests. > UsernameAndPasswordFieldSeparatedByRadioButton > > Can you please have a look? > > Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 > > We are doing test-runs for upcoming 'EWS for API tests'. If this is a false > positive, please let us know. I believe this is a false positive (see: <https://bugs.webkit.org/show_bug.cgi?id=189165>).
WebKit Commit Bot
Comment 5 2019-01-17 08:00:20 PST
Comment on attachment 359334 [details] Patch Clearing flags on attachment: 359334 Committed r240108: <https://trac.webkit.org/changeset/240108>
WebKit Commit Bot
Comment 6 2019-01-17 08:00:22 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-17 08:01:38 PST
<rdar://problem/47351239>
Note You need to log in before you can comment on or make changes to this bug.