Bug 193520 - [LFC][BFC] For height computation, the bottom edge of the last line box value should not include top border/padding
Summary: [LFC][BFC] For height computation, the bottom edge of the last line box value...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-16 16:34 PST by zalan
Modified: 2019-01-17 08:01 PST (History)
11 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2019-01-16 16:40 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-16 16:34:01 PST 
it needs to be in the coordinate system of the containing block's content box.
Comment 1 zalan 2019-01-16 16:40:36 PST 
Created attachment 359334 [details]
Patch
Comment 2 Aakash Jain 2019-01-17 04:55:20 PST 
This patch seems to break an API test: TestWebKitAPI.WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton

Can you please have a look?

Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185

We are doing test-runs for upcoming 'EWS for API tests'. If this is a false positive, please let us know.
Comment 3 zalan 2019-01-17 06:44:22 PST 
(In reply to Aakash Jain from comment #2)
> This patch seems to break an API test:
> TestWebKitAPI.WKWebViewAutofillTests.
> UsernameAndPasswordFieldSeparatedByRadioButton
> 
> Can you please have a look?
> 
> Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185
> 
> We are doing test-runs for upcoming 'EWS for API tests'. If this is a false
> positive, please let us know.
Sure but this code is behind a run time flag and the flag is not enabled.
Comment 4 Wenson Hsieh 2019-01-17 07:13:11 PST 
(In reply to Aakash Jain from comment #2)
> This patch seems to break an API test:
> TestWebKitAPI.WKWebViewAutofillTests.
> UsernameAndPasswordFieldSeparatedByRadioButton
> 
> Can you please have a look?
> 
> Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185
> 
> We are doing test-runs for upcoming 'EWS for API tests'. If this is a false
> positive, please let us know.

I believe this is a false positive (see: <https://bugs.webkit.org/show_bug.cgi?id=189165>).
Comment 5 WebKit Commit Bot 2019-01-17 08:00:20 PST 
Comment on attachment 359334 [details]
Patch

Clearing flags on attachment: 359334

Committed r240108: <https://trac.webkit.org/changeset/240108>
Comment 6 WebKit Commit Bot 2019-01-17 08:00:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-17 08:01:38 PST 
<rdar://problem/47351239>