Bug 193511 – REGRESSION(294714@main): [GTK][WPE] http/tests/images/mp4-partial-load.html fails

• Status: REOPENED
• Component: WebKitGTK

[Alicia Boya García]

http/tests/images/mp4-partial-load.html

Fails since r239665:r239668, probable culprit:

commit 388b8f149ec81a3bd291be3176f0993dd8b699ea
Author: [e-mail] <[e-mail]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Jan 7 10:40:04 2019 +0000

    REGRESSION(r239636): ImageDecoder::setEncodedDataStatusChangeCallback() can be called on a null decoder
    https://bugs.webkit.org/show_bug.cgi?id=193187
    
    Reviewed by Philippe Normand.
    
    * platform/graphics/ImageSource.cpp:
    (WebCore::ImageSource::ensureDecoderAvailable): Bail before calling the
    setEncodedDataStatusChangeCallback() method when the returned
    ImageDecoder object is null.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239668 268f45cc-cd09-0410-ab3c-d52691b4dbfc


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/images/mp4-partial-load-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/images/mp4-partial-load-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS img.naturalWidth became 320
+FAIL Took too long
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Diego Pino]

The test is passing since r261925. Likely fixed by r261922. Removed from test expectations in r261989.

[Diego Pino]

This test started failing for WebKitGTK and WPEWebKit on the interval [294710-294717]@main:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fimages%2Fmp4-partial-load.html&platform=GTK&platform=WPE

https://build.webkit.org/results/WPE-Linux-64-bit-Release-Tests/298351%40main%20%2822261%29/http/tests/images/mp4-partial-load-diff.txt

--- /home/buildbot/worker/WPE-Linux-64-bit-Release-Tests/build/layout-test-results/http/tests/images/mp4-partial-load-expected.txt
+++ /home/buildbot/worker/WPE-Linux-64-bit-Release-Tests/build/layout-test-results/http/tests/images/mp4-partial-load-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS img.naturalWidth became 320
+FAIL Received an erorr loading image
 PASS successfullyParsed is true
 
 TEST COMPLETE

Within the range, the most likely commit to have caused the regression was 294714@main. I locally reverted that commit and the test passes.