Bug 193510 - Add infrastructure to enable/disable ITP Debug Mode through Preferences
Summary: Add infrastructure to enable/disable ITP Debug Mode through Preferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-16 14:54 PST by John Wilander
Modified: 2019-01-17 13:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.33 KB, patch)
2019-01-17 11:00 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (11.36 KB, patch)
2019-01-17 11:17 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (13.45 KB, patch)
2019-01-17 12:11 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-01-16 14:54:37 PST 
We need some infrastructure to allow the hosting app to turn on ITP Debug Mode.
Comment 1 Radar WebKit Bug Importer 2019-01-16 14:55:27 PST 
<rdar://problem/47330969>
Comment 2 John Wilander 2019-01-17 11:00:59 PST 
Created attachment 359391 [details]
Patch
Comment 3 John Wilander 2019-01-17 11:17:17 PST 
Created attachment 359393 [details]
Patch
Comment 4 John Wilander 2019-01-17 11:17:41 PST 
Fixed the WPE build error.
Comment 5 John Wilander 2019-01-17 12:11:36 PST 
Created attachment 359402 [details]
Patch
Comment 6 John Wilander 2019-01-17 12:11:52 PST 
Fixed the test failure.
Comment 7 John Wilander 2019-01-17 13:16:45 PST 
The mac-wk2 bot seems to be in bad shape. The test failures are unrelated to this patch.
Comment 8 Dean Jackson 2019-01-17 13:20:40 PST 
Comment on attachment 359402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359402&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::RuntimeEnabledFeatures::setItpDebugModeEnabled):
> +        (WebCore::RuntimeEnabledFeatures::itpDebugModeEnabled const):

Why not capitalise ITP?
Comment 9 John Wilander 2019-01-17 13:26:28 PST 
(In reply to Dean Jackson from comment #8)
> Comment on attachment 359402 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359402&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        (WebCore::RuntimeEnabledFeatures::setItpDebugModeEnabled):
> > +        (WebCore::RuntimeEnabledFeatures::itpDebugModeEnabled const):
> 
> Why not capitalise ITP?

I started out that way but it lead to all kinds of ugliness in generated code. Maybe I backed out most of that stuff but generally, vanilla camel casing works best.
Comment 10 John Wilander 2019-01-17 13:26:48 PST 
Thanks for the review, Dean!
Comment 11 WebKit Commit Bot 2019-01-17 13:36:54 PST 
Comment on attachment 359402 [details]
Patch

Clearing flags on attachment: 359402

Committed r240129: <https://trac.webkit.org/changeset/240129>
Comment 12 WebKit Commit Bot 2019-01-17 13:36:56 PST 
All reviewed patches have been landed.  Closing bug.