RESOLVED FIXED 193501
Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function 
https://bugs.webkit.org/show_bug.cgi?id=193501
Summary Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a f...
Matt Baker
Reported 2019-01-16 11:40:53 PST
This bug was introduced in https://webkit.org/b/192917. Steps to Reproduce: 1. Inspect daringfireball.net 2. Open Elements tab 3. Reload the page TypeError:​ this._indexesForSubtree is not a function. (In 'this._indexesForSubtree(child)​', 'this._indexesForSubtree' is undefined)​ (at TreeOutline.js:​332:​53)​ removeChildAtIndex @ TreeOutline.js:​332:​53 _updateChildren @ DOMTreeElement.js:​494:​36 _updateChildren @ [native code]​ getChildNodes @ DOMNode.js:​490:​25 updateChildren @ DOMTreeElement.js:​420:​45 _updateModifiedNodes @ DOMTreeUpdater.js:​125:​49 performWork @ Utilities.js:​1501:​47
Attachments
Patch (1.77 KB, patch)
2019-01-16 11:42 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-16 11:41:29 PST
<rdar://problem/47323967>
Matt Baker
Comment 2 2019-01-16 11:42:32 PST
Created attachment 359285 [details] Patch
Nikita Vasilyev
Comment 3 2019-01-16 13:20:15 PST
Comment on attachment 359285 [details] Patch Looks good. I can't reproduce the exception anymore.
Joseph Pecoraro
Comment 4 2019-01-16 13:39:11 PST
Comment on attachment 359285 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-01-16 14:04:41 PST
Comment on attachment 359285 [details] Patch Clearing flags on attachment: 359285 Committed r240051: <https://trac.webkit.org/changeset/240051>
WebKit Commit Bot
Comment 6 2019-01-16 14:04:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.