Bug 19348 - REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
Summary: REGRESSION (r34193): Setting the size of a frame with javascript document.bo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Major
Assignee: Nobody
URL: http://www.smilecms.com/webkit/expand...
Keywords: InRadar, Regression
: 20140 (view as bug list)
Depends on:
Reported: 2008-06-01 04:31 PDT by Peer Bremer
Modified: 2008-08-12 11:28 PDT (History)
3 users (show)

See Also:

Call the base class implementation last (44.89 KB, patch)
2008-08-12 11:12 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peer Bremer 2008-06-01 04:31:03 PDT
calling a javascript function:

function resizeFrame(contractsetting){
or using document.body.rows='100,*';
No longer alters teh existing frame set height.
See the example at:

Works with Safari 3.1.1 (4525.18) but not with the latest webkit builds
Comment 1 Alexey Proskuryakov 2008-06-02 00:09:12 PDT
Confirmed as a regression with r34291. Resizing the window to trigger relayout fixes the height.
Comment 2 Alexey Proskuryakov 2008-06-02 00:10:01 PDT
Comment 3 mitz 2008-06-02 11:10:42 PDT
Caused by moving the base class recalcStyle() to the beginning of HTMLFrameSetElement::recalcStyle() in <http://trac.webkit.org/changeset/34193#file15>.
Comment 4 mitz 2008-07-23 13:30:16 PDT
*** Bug 20140 has been marked as a duplicate of this bug. ***
Comment 5 Peer Bremer 2008-08-11 03:25:05 PDT
There is also a redraw problem when a page is reloaded inside a frame set and a div uses an image as a background. Part of the background stays white and does not show the image. Solved when the window is resized.
Comment 6 mitz 2008-08-12 11:12:44 PDT
Created attachment 22753 [details]
Call the base class implementation last
Comment 7 Darin Adler 2008-08-12 11:24:55 PDT
Comment on attachment 22753 [details]
Call the base class implementation last

Comment 8 mitz 2008-08-12 11:28:21 PDT
Fixed in <http://trac.webkit.org/changeset/35690>.