RESOLVED FIXED 19348
REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works 
https://bugs.webkit.org/show_bug.cgi?id=19348
Summary REGRESSION (r34193): Setting the size of a frame with javascript document.bo...
Peer Bremer
Reported 2008-06-01 04:31:03 PDT
calling a javascript function: function resizeFrame(contractsetting){ document.body.rows=contractsetting; } or using document.body.rows='100,*'; No longer alters teh existing frame set height. See the example at: http://www.smilecms.com/webkit/expand_frame.html Works with Safari 3.1.1 (4525.18) but not with the latest webkit builds
Attachments
Call the base class implementation last (44.89 KB, patch)
2008-08-12 11:12 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-06-02 00:09:12 PDT
Confirmed as a regression with r34291. Resizing the window to trigger relayout fixes the height.
Alexey Proskuryakov
Comment 2 2008-06-02 00:10:01 PDT
<rdar://problem/5978447>
mitz
Comment 3 2008-06-02 11:10:42 PDT
Caused by moving the base class recalcStyle() to the beginning of HTMLFrameSetElement::recalcStyle() in <http://trac.webkit.org/changeset/34193#file15>.
mitz
Comment 4 2008-07-23 13:30:16 PDT
*** Bug 20140 has been marked as a duplicate of this bug. ***
Peer Bremer
Comment 5 2008-08-11 03:25:05 PDT
There is also a redraw problem when a page is reloaded inside a frame set and a div uses an image as a background. Part of the background stays white and does not show the image. Solved when the window is resized.
mitz
Comment 6 2008-08-12 11:12:44 PDT
Created attachment 22753 [details] Call the base class implementation last
Darin Adler
Comment 7 2008-08-12 11:24:55 PDT
Comment on attachment 22753 [details] Call the base class implementation last r=me
mitz
Comment 8 2008-08-12 11:28:21 PDT
Fixed in <http://trac.webkit.org/changeset/35690>.
Note You need to log in before you can comment on or make changes to this bug.