RESOLVED FIXED 193479
[WHLSL] Add the function stage checker 
https://bugs.webkit.org/show_bug.cgi?id=193479
Summary [WHLSL] Add the function stage checker
Myles C. Maxfield
Reported 2019-01-15 19:00:04 PST
[WHLSL] Add the function stage checker
Attachments
Patch (25.29 KB, patch)
2019-01-15 19:01 PST, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-01-15 19:01:04 PST
Created attachment 359241 [details] Patch
Robin Morisset
Comment 2 2019-01-16 10:54:57 PST
Comment on attachment 359241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359241&action=review LGTM, apart from the one question I added. > Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:62 > + Visitor::visit(callExpression); Does this recurse into the body of the callee, or do we need something like callExpression.function() here too?
Myles C. Maxfield
Comment 3 2019-01-16 17:05:18 PST
Comment on attachment 359241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359241&action=review >> Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:62 >> + Visitor::visit(callExpression); > > Does this recurse into the body of the callee, or do we need something like callExpression.function() here too? Good catch.
Myles C. Maxfield
Comment 4 2019-01-16 17:08:32 PST
Committed r240098: <https://trac.webkit.org/changeset/240098>
Radar WebKit Bug Importer
Comment 5 2019-01-16 17:09:29 PST
<rdar://problem/47335529>
Robin Morisset
Comment 6 2019-01-16 18:02:58 PST
You probably want some kind of memoization per function to avoid an exponential worst case complexity. The problem as I see it is that if you recurse into the callee each time, if foo1 calls foo2 twice and foo2 calls foo3 twice, etc.., by foo10 you are running every check 1024 times.
Note You need to log in before you can comment on or make changes to this bug.