Bug 193474 – Web Inspector: fix Xcode project file list after r239976

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 359233 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 359233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359233&action=review

This change looks partially complete (enough to fix the project file but not what we would normally expect for derived sources)

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:2591
> -		9175CE5C21E281ED00DF2C28 /* JSInspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C28 /* InspectorAuditDOMObject.h */; };
> +		9175CE5C21E281ED00DF2C28 /* JSInspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C28 /* JSInspectorAuditDOMObject.h */; };
>  		9175CE5E21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h */; };
> -		9175CE5E21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h */; };
> +		9175CE5E21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h */; };

I would expect each of these to be like JSCommandLineAPIHost.h.

So I'd expect this section to be updated:

		1C5FAECA0DCFD8C900D58F78 /* Inspector */ = {
			isa = PBXGroup;
			children = (
				A584FE2518637DAB00843B10 /* CommandLineAPIModuleSource.h */,
				A584FE391864E2D800843B10 /* JSCommandLineAPIHost.cpp */,
				A584FE3A1864E2D800843B10 /* JSCommandLineAPIHost.h */,
				7A0E771C10C00DB100A0276E /* JSInspectorFrontendHost.cpp */,
				7A0E771D10C00DB100A0276E /* JSInspectorFrontendHost.h */,
			);
			name = Inspector;
			sourceTree = "<group>";
		};

Something alongside this that is just a "<foo> in Headers":

		A584FE3C1864E2D800843B10 /* JSCommandLineAPIHost.h in Headers */,

The WebCore.xcodeproj should show the resources in the sidebar under:

    bindings/js/Derived Sources/Inspector/...

[Devin Rousso]

Created attachment 359397 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 359397 [details]
Patch

Clearing flags on attachment: 359397

Committed r240135: <https://trac.webkit.org/changeset/240135>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47368581>