Bug 193469 - [WHLSL] Delete the 'restricted' keyword
Summary: [WHLSL] Delete the 'restricted' keyword
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-15 15:51 PST by Myles C. Maxfield
Modified: 2019-01-16 17:00 PST (History)
7 users (show)

See Also:


Attachments
Patch (25.13 KB, patch)
2019-01-15 15:52 PST, Myles C. Maxfield
rmorisset: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-01-15 15:51:24 PST
[WHLSL] Delete the 'restricted' keyword
Comment 1 Myles C. Maxfield 2019-01-15 15:52:52 PST
Created attachment 359215 [details]
Patch
Comment 2 Robin Morisset 2019-01-15 16:00:07 PST
Comment on attachment 359215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359215&action=review

LGTM

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:74
> +    if (minimumCostCandidates.size() == 1)

Maybe rename minimumCostCandidates, since I don't think there is a notion of cost anymore.
Comment 3 Myles C. Maxfield 2019-01-15 16:03:05 PST
(In reply to Robin Morisset from comment #2)
> Comment on attachment 359215 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359215&action=review
> 
> LGTM
> 
> > Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:74
> > +    if (minimumCostCandidates.size() == 1)
> 
> Maybe rename minimumCostCandidates, since I don't think there is a notion of
> cost anymore.

There is a notion of cost.

void foo(int) { ... }
void foo(uint) { ... }
foo(4) resolves to a different overload than foo(4u)
Comment 4 Dean Jackson 2019-01-16 12:05:17 PST
r=me too
Comment 5 Myles C. Maxfield 2019-01-16 16:59:22 PST
Committed r240097: <https://trac.webkit.org/changeset/240097>
Comment 6 Radar WebKit Bug Importer 2019-01-16 17:00:29 PST
<rdar://problem/47335266>