Bug 193466 - Fix incorrect ASSERT added in r239840
Summary: Fix incorrect ASSERT added in r239840
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-15 15:01 PST by Eric Carlson
Modified: 2019-01-15 16:09 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2019-01-15 15:08 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (1.53 KB, patch)
2019-01-15 15:29 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-01-15 15:01:48 PST
UserMediaCaptureManager::Source::Source asserts when creating an Audio stream.
Comment 1 Eric Carlson 2019-01-15 15:04:30 PST
<rdar://problem/47095142>
Comment 2 Eric Carlson 2019-01-15 15:08:01 PST
Created attachment 359209 [details]
Patch
Comment 3 youenn fablet 2019-01-15 15:15:43 PST
Comment on attachment 359209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65
> +        ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone);

Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)?
Comment 4 Eric Carlson 2019-01-15 15:28:16 PST
Comment on attachment 359209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review

>> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65
>> +        ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone);
> 
> Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)?

Good idea, thanks.
Comment 5 Eric Carlson 2019-01-15 15:29:32 PST
Created attachment 359213 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-01-15 16:08:58 PST
Comment on attachment 359213 [details]
Patch for landing

Clearing flags on attachment: 359213

Committed r240017: <https://trac.webkit.org/changeset/240017>
Comment 7 WebKit Commit Bot 2019-01-15 16:09:00 PST
All reviewed patches have been landed.  Closing bug.