Bug 193466 – Fix incorrect ASSERT added in r239840

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

UserMediaCaptureManager::Source::Source asserts when creating an Audio stream.

[Eric Carlson]

<rdar://problem/47095142>

[Eric Carlson]

Created attachment 359209 [details]
Patch

[youenn fablet]

Comment on attachment 359209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65
> +        ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone);

Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)?

[Eric Carlson]

Comment on attachment 359209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review

>> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65
>> +        ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone);
> 
> Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)?

Good idea, thanks.

[Eric Carlson]

Created attachment 359213 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 359213 [details]
Patch for landing

Clearing flags on attachment: 359213

Committed r240017: <https://trac.webkit.org/changeset/240017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.