Bug 193453 - Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent
Summary: Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-15 10:03 PST by Per Arne Vollan
Modified: 2019-01-15 11:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2019-01-15 10:05 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2019-01-15 10:12 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-01-15 10:03:23 PST 
It should be added to:

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 
WebProcess/com.apple.WebProcess.sb.in
Comment 1 Per Arne Vollan 2019-01-15 10:03:43 PST 
rdar://problem/47268166
Comment 2 Per Arne Vollan 2019-01-15 10:05:36 PST 
Created attachment 359170 [details]
Patch
Comment 3 Brent Fulgham 2019-01-15 10:06:59 PST 
Comment on attachment 359170 [details]
Patch

Great -- thank you for adding this.

It looks like you have some smart quotes, which will break things. Can you please fix?
Comment 4 Brent Fulgham 2019-01-15 10:07:26 PST 
Comment on attachment 359170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359170&action=review

> Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:164
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

You've got a "â" as the closing quote.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:194
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

Ditto

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:613
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

Ditto
Comment 5 Per Arne Vollan 2019-01-15 10:12:24 PST 
Created attachment 359172 [details]
Patch
Comment 6 Per Arne Vollan 2019-01-15 10:13:06 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 359170 [details]
> Patch
> 
> Great -- thank you for adding this.
> 
> It looks like you have some smart quotes, which will break things. Can you
> please fix?

Ah, good catch! I have updated the patch. Thanks for reviewing!
Comment 7 Brent Fulgham 2019-01-15 11:05:58 PST 
Comment on attachment 359172 [details]
Patch

Looks great. r=me!
Comment 8 WebKit Commit Bot 2019-01-15 11:34:18 PST 
Comment on attachment 359172 [details]
Patch

Clearing flags on attachment: 359172

Committed r239994: <https://trac.webkit.org/changeset/239994>
Comment 9 WebKit Commit Bot 2019-01-15 11:34:20 PST 
All reviewed patches have been landed.  Closing bug.