Bug 193444 - [SOUP] Remove usage of NetworkProcess::singleton()
Summary: [SOUP] Remove usage of NetworkProcess::singleton()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
Depends on:
Reported: 2019-01-15 06:20 PST by Claudio Saavedra
Modified: 2019-02-05 08:03 PST (History)
5 users (show)

See Also:

Patch (4.10 KB, patch)
2019-01-15 06:20 PST, Claudio Saavedra
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2019-01-15 06:20:04 PST
[SOUP] Remove usage of NetworkProcess::singleton()
Comment 1 Claudio Saavedra 2019-01-15 06:20:32 PST
Created attachment 359158 [details]
Comment 2 Alex Christensen 2019-01-15 16:37:23 PST
This is a step in the right direction.  Thanks!
We should still move the soup things from NetworkProcessCreationParameters to NetworkSessionCreationParameters, and keep in mind the WebsiteDataStoreParameters member of NetworkProcessCreationParameters is going to eventually be detached.
Comment 3 Alex Christensen 2019-01-15 16:39:27 PST
Also, is GTK still using anything in LegacyCustomProtocolManager?  It would be great if we could remove that.
Comment 4 Michael Catanzaro 2019-01-15 19:36:15 PST
That's used in webkitWebContextStartLoadingCustomProtocol and webkitWebContextStopLoadingCustomProtocol in WebKitWebContext.cpp. It's also used in WebKitCustomProtocolManagerClient.[cpp,h], but I guess that class probably disappears if LegacyCustomProtocolManager is removed. I think those are the only places. Not sure how much effort to replace, though; there's a lot of code in LegacyCustomProtocolManagerSoup. Worth a separate bug report to sort this out.