Bug 193441 – [JSC] printf-type mishap

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Claudio Saavedra]

[2/1678] Building CXX object Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o
../../Source/JavaScriptCore/jsc.cpp: In function ‘int jscmain(int, char**)’:
../../Source/JavaScriptCore/jsc.cpp:2941:16: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
         printf("Memory Footprint:\n    Current Footprint: %llu\n    Peak Footprint: %llu\n", footprint.current, footprint.peak);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~
../../Source/JavaScriptCore/jsc.cpp:2941:16: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]

[Claudio Saavedra]

Created attachment 359151 [details]
Patch

[Saam Barati]

Comment on attachment 359151 [details]
Patch

This doesn't seem to build. Isn't there something for size_t?

[Mark Lam]

Comment on attachment 359151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359151&action=review

> Source/JavaScriptCore/jsc.cpp:2941
> -        printf("Memory Footprint:\n    Current Footprint: %llu\n    Peak Footprint: %llu\n", footprint.current, footprint.peak);
> +        printf("Memory Footprint:\n    Current Footprint: %lu\n    Peak Footprint: %lu\n", footprint.current, footprint.peak);

Saam is correct.  You made this work for 32-bit builds but broke 64-bit builds.  Instead, you should use size_t like so:

    printf("Memory Footprint:\n Current Footprint: %zu\n Peak Footprint: %zu\n", static_cast<size_t>(footprint.current), static_cast<size_t>(footprint.peak));

[Claudio Saavedra]

Tomas Popela already pushed a fix in https://trac.webkit.org/changeset/239981/webkit.

[Radar WebKit Bug Importer]

<rdar://problem/47309674>