RESOLVED FIXED 193432
[WHLSL] Add the high zombie finder 
https://bugs.webkit.org/show_bug.cgi?id=193432
Summary [WHLSL] Add the high zombie finder
Myles C. Maxfield
Reported 2019-01-14 20:58:36 PST
[WHLSL] Add the high zombie finder
Attachments
Patch (8.36 KB, patch)
2019-01-14 20:59 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2019-01-15 16:16 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (17.52 KB, patch)
2019-01-15 19:31 PST, Myles C. Maxfield 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-highsierra (2.15 MB, application/zip)
2019-01-15 21:42 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2019-01-14 20:59:25 PST
Created attachment 359130 [details] Patch
Myles C. Maxfield
Comment 2 2019-01-14 22:10:44 PST
Comment on attachment 359130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359130&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLHighZombieFinder.h:32 > +#include "WHLSLFunctionAttribute.h" > +#include "WHLSLSemantic.h" > +#include "WHLSLTypeArgument.h" These can be deleted.
Myles C. Maxfield
Comment 3 2019-01-14 22:28:35 PST
Comment on attachment 359130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359130&action=review > Source/WebCore/ChangeLog:6 > + This is a translation of https://github.com/gpuweb/WHLSL/blob/master/Source/HighZombieFinder.mjs into C++. Need a "reviewed by" line
Robin Morisset
Comment 4 2019-01-15 10:20:39 PST
Comment on attachment 359130 [details] Patch This pass is purely used as an assertion in the original javascript implementation, and I think was used for debugging some specific problems. Please at least copy the comments saying that this pass is only to be called after some lowering eliminated the high-level constructs it errors on. Ideally, I would like to defer such non-required passes until we can hook-up enough of the compiler to run the test-suite.
Myles C. Maxfield
Comment 5 2019-01-15 16:16:47 PST
Created attachment 359218 [details] Patch
Robin Morisset
Comment 6 2019-01-15 16:19:10 PST
LGTM
Myles C. Maxfield
Comment 7 2019-01-15 19:31:01 PST
Created attachment 359247 [details] Patch
EWS Watchlist
Comment 8 2019-01-15 21:42:47 PST
Comment on attachment 359247 [details] Patch Attachment 359247 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10768496 New failing tests: compositing/backing/animate-into-view.html
EWS Watchlist
Comment 9 2019-01-15 21:42:49 PST
Created attachment 359255 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Myles C. Maxfield
Comment 10 2019-01-16 02:53:30 PST
Committed r240033: <https://trac.webkit.org/changeset/240033>
Radar WebKit Bug Importer
Comment 11 2019-01-16 02:55:18 PST
<rdar://problem/47312352>
Note You need to log in before you can comment on or make changes to this bug.