[WHLSL] Add the high zombie finder
Created attachment 359130 [details] Patch
Comment on attachment 359130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359130&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLHighZombieFinder.h:32 > +#include "WHLSLFunctionAttribute.h" > +#include "WHLSLSemantic.h" > +#include "WHLSLTypeArgument.h" These can be deleted.
Comment on attachment 359130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359130&action=review > Source/WebCore/ChangeLog:6 > + This is a translation of https://github.com/gpuweb/WHLSL/blob/master/Source/HighZombieFinder.mjs into C++. Need a "reviewed by" line
Comment on attachment 359130 [details] Patch This pass is purely used as an assertion in the original javascript implementation, and I think was used for debugging some specific problems. Please at least copy the comments saying that this pass is only to be called after some lowering eliminated the high-level constructs it errors on. Ideally, I would like to defer such non-required passes until we can hook-up enough of the compiler to run the test-suite.
Created attachment 359218 [details] Patch
LGTM
Created attachment 359247 [details] Patch
Comment on attachment 359247 [details] Patch Attachment 359247 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10768496 New failing tests: compositing/backing/animate-into-view.html
Created attachment 359255 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Committed r240033: <https://trac.webkit.org/changeset/240033>
<rdar://problem/47312352>