Bug 193406 - webkitpy: Expose device_type from host-like objects
Summary: webkitpy: Expose device_type from host-like objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-14 12:51 PST by Jonathan Bedard
Modified: 2019-01-14 14:02 PST (History)
6 users (show)

See Also:


Attachments
Patch (17.37 KB, patch)
2019-01-14 12:55 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-01-14 12:51:00 PST
Platform devices define a device_type. Conceptually, device_type is relevant for other machines as well. Given that we would like to support device specific expectations, it makes sense for host objects to expose information about device type.
Comment 1 Radar WebKit Bug Importer 2019-01-14 12:51:29 PST
<rdar://problem/47262305>
Comment 2 Jonathan Bedard 2019-01-14 12:55:44 PST
Created attachment 359070 [details]
Patch
Comment 3 Jonathan Bedard 2019-01-14 12:57:08 PST
Note that this is for <https://bugs.webkit.org/show_bug.cgi?id=192162>
Comment 4 WebKit Commit Bot 2019-01-14 14:02:24 PST
Comment on attachment 359070 [details]
Patch

Clearing flags on attachment: 359070

Committed r239945: <https://trac.webkit.org/changeset/239945>
Comment 5 WebKit Commit Bot 2019-01-14 14:02:26 PST
All reviewed patches have been landed.  Closing bug.