Bug 193400 - Remove the specific handling of ephemeral sessions from CacheStorage::Engine::from
Summary: Remove the specific handling of ephemeral sessions from CacheStorage::Engine:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-14 09:34 PST by youenn fablet
Modified: 2019-01-15 14:35 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2019-01-14 09:38 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2019-01-15 08:29 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-01-14 09:34:53 PST
CacheStorage::Engine::from should query the engine map with the default private session ID in case of ephemeral sessions
Comment 1 youenn fablet 2019-01-14 09:38:15 PST
Created attachment 359043 [details]
Patch
Comment 2 Alex Christensen 2019-01-14 18:33:09 PST
Comment on attachment 359043 [details]
Patch

I think we should just remove the use of legacyPrivateSessionID here.  Why are you expanding it?
Comment 3 youenn fablet 2019-01-15 08:26:27 PST
(In reply to Alex Christensen from comment #2)
> Comment on attachment 359043 [details]
> Patch
> 
> I think we should just remove the use of legacyPrivateSessionID here.  Why
> are you expanding it?

True, this is no longer needed. I will remove these two lines instead.
Comment 4 youenn fablet 2019-01-15 08:29:52 PST
Created attachment 359161 [details]
Patch
Comment 5 WebKit Commit Bot 2019-01-15 14:34:40 PST
Comment on attachment 359161 [details]
Patch

Clearing flags on attachment: 359161

Committed r240009: <https://trac.webkit.org/changeset/240009>
Comment 6 WebKit Commit Bot 2019-01-15 14:34:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-15 14:35:50 PST
<rdar://problem/47297048>