Bug 193384 - Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
Summary: Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show complet...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-12 16:21 PST by Nikita Vasilyev
Modified: 2019-01-14 15:23 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2019-01-12 19:23 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-01-12 16:21:01 PST
Steps:
1. Add an event breakpoint
2. Type "DOM"

Expected:
Completion shows events that start with "DOM", e.g. "DOMActivate", "DOMCharacterDataModified", and etc.

Actual:
No completion is shown.

Notes:
Typing lowercase "dom" shows events that start with "DOM".
Comment 1 Devin Rousso 2019-01-12 19:23:28 PST
Created attachment 358999 [details]
Patch
Comment 2 Nikita Vasilyev 2019-01-14 13:13:51 PST
Comment on attachment 358999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358999&action=review

> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:109
> +                    if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value.toLowerCase()))

This fixes the bug! I'd r+ 👍
Comment 3 Joseph Pecoraro 2019-01-14 14:56:20 PST
Comment on attachment 358999 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-01-14 15:22:52 PST
Comment on attachment 358999 [details]
Patch

Clearing flags on attachment: 358999

Committed r239955: <https://trac.webkit.org/changeset/239955>
Comment 5 WebKit Commit Bot 2019-01-14 15:22:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-14 15:23:28 PST
<rdar://problem/47267836>