RESOLVED FIXED 193383
[LFC] Block/InlinFormattingContext should take Block/InlineFormattingState 
https://bugs.webkit.org/show_bug.cgi?id=193383
Summary [LFC] Block/InlinFormattingContext should take Block/InlineFormattingState
zalan
Reported 2019-01-12 12:44:49 PST
This is a just downcast really.
Attachments
Patch (13.34 KB, patch)
2019-01-12 12:47 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-01-12 12:47:00 PST
Created attachment 358995 [details] Patch
Antti Koivisto
Comment 2 2019-01-12 12:55:03 PST
Comment on attachment 358995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358995&action=review > Source/WebCore/layout/FormattingContext.h:-68 > - FormattingState& formattingState() const; I think you could also keep this as-is (and keep m_formattingState private). You can override a function with a more specific return type in the subclass: BlockFormattingState& formattingState() const { return downcast<BlockFormattingState>(FormattingContext::formattingState()); }
zalan
Comment 3 2019-01-12 13:28:21 PST
Committed r239903: <https://trac.webkit.org/changeset/239903>
Radar WebKit Bug Importer
Comment 4 2019-01-12 13:29:33 PST
<rdar://problem/47234302>
Note You need to log in before you can comment on or make changes to this bug.