Web API Statistics Collection is not ready and thus should not affect what's processed and saved in the ResourceLoadStatistics data model.
<rdar://problem/45388584>
Created attachment 358957 [details] Patch
Comment on attachment 358957 [details] Patch Ah, great! Thank you for taking care of this. r=me
Thanks for the review, Brent! I'll wait for green bubbles before landing.
mac-debug failing tests are unrelated.
Comment on attachment 358957 [details] Patch Clearing flags on attachment: 358957 Committed r239888: <https://trac.webkit.org/changeset/239888>
All reviewed patches have been landed. Closing bug.
It looks like the changes in https://trac.webkit.org/changeset/239888/webkit has caused 5 API tests to fail. 3 are failing on release and 5 are failing on debug. Build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20%28Tests%29/builds/7194 Log: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6210/steps/run-api-tests/logs/stdio The tests seem to be failing to open a database Example: TestWebKitAPI.WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming /Volumes/Data/slave/highsierra-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:140 Expected equality of these values: [getNextMessage().body UTF8String] Which is: "Exception: ReferenceError: Can't find variable: openDatabase" "Exception: QuotaExceededError: The quota has been exceeded."
These API tests may very well be for this exact feature. I’ll have a look today.
I've now run these API tests on my machine with the changes in the patch and they pass. Additionally, they are unrelated to the code change.
After getting a repro case and bisecting the revisions I found 239888 to not be at fault here.
Thanks, Truitt.