Bug 193369 - Fix style CFNetworkSPI style checker warnings from r239698
Summary: Fix style CFNetworkSPI style checker warnings from r239698
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-11 15:11 PST by Devin Rousso
Modified: 2019-01-11 16:41 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2019-01-11 15:12 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-01-11 15:11:05 PST 
<https://webkit.org/b/191539#c36>:
    ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:214:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:94:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:134:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:661:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
Comment 1 Devin Rousso 2019-01-11 15:12:53 PST 
Created attachment 358954 [details]
Patch
Comment 2 Joseph Pecoraro 2019-01-11 15:24:16 PST 
Comment on attachment 358954 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-01-11 16:40:20 PST 
Comment on attachment 358954 [details]
Patch

Clearing flags on attachment: 358954

Committed r239884: <https://trac.webkit.org/changeset/239884>
Comment 4 WebKit Commit Bot 2019-01-11 16:40:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-11 16:41:28 PST 
<rdar://problem/47224762>