Bug 193362 - webkitpy: Support alternate simctl device list output
Summary: webkitpy: Support alternate simctl device list output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-11 13:45 PST by Jonathan Bedard
Modified: 2019-01-14 13:32 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2019-01-11 13:52 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2019-01-11 14:11 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2019-01-14 13:20 PST, Jonathan Bedard
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-01-11 13:45:04 PST
There are a few different variations of simctl device list outputs, we should support them.
Comment 1 Jonathan Bedard 2019-01-11 13:45:21 PST
<rdar://problem/47122965>
Comment 2 Jonathan Bedard 2019-01-11 13:52:24 PST
Created attachment 358939 [details]
Patch
Comment 3 Lucas Forschler 2019-01-11 14:07:33 PST
Comment on attachment 358939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358939&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:137
> +                for devices_for_runtime in simctl_json['devices']:

it seems strange to set devices_for_runtime to an empty list, then use it as an iterator here?
Comment 4 Jonathan Bedard 2019-01-11 14:11:08 PST
Created attachment 358945 [details]
Patch
Comment 5 Jonathan Bedard 2019-01-11 14:12:17 PST
(In reply to Lucas Forschler from comment #3)
> Comment on attachment 358939 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358939&action=review
> 
> > Tools/Scripts/webkitpy/xcode/simulated_device.py:137
> > +                for devices_for_runtime in simctl_json['devices']:
> 
> it seems strange to set devices_for_runtime to an empty list, then use it as
> an iterator here?

Surprised this code worked! Just uploaded a patch to fix it.
Comment 6 WebKit Commit Bot 2019-01-11 14:48:21 PST
Comment on attachment 358945 [details]
Patch

Clearing flags on attachment: 358945

Committed r239878: <https://trac.webkit.org/changeset/239878>
Comment 7 WebKit Commit Bot 2019-01-11 14:48:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-01-11 14:49:28 PST
<rdar://problem/47221502>
Comment 9 Jonathan Bedard 2019-01-14 13:20:45 PST
Reopening to attach new patch.
Comment 10 Jonathan Bedard 2019-01-14 13:20:46 PST
Created attachment 359074 [details]
Patch
Comment 11 Jonathan Bedard 2019-01-14 13:32:51 PST
Committed r239939: <https://trac.webkit.org/changeset/239939>