Bug 193359 - Prevent WorkerRunLoop::runInMode from spinning in nested cases
Summary: Prevent WorkerRunLoop::runInMode from spinning in nested cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-11 13:04 PST by youenn fablet
Modified: 2019-01-16 11:07 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.86 KB, patch)
2019-01-14 09:45 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.92 KB, patch)
2019-01-14 15:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-highsierra (2.56 MB, application/zip)
2019-01-14 17:34 PST, EWS Watchlist 		no flags Details
Patch (15.76 KB, patch)
2019-01-14 17:51 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (15.77 KB, patch)
2019-01-16 10:26 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-01-11 13:04:44 PST 
CacheStorage::Engine should create one engine for all ephemeral sessions
Comment 1 youenn fablet 2019-01-11 13:04:56 PST 
<rdar://problem/46345353>
Comment 2 youenn fablet 2019-01-14 09:45:48 PST 
Created attachment 359046 [details]
Patch
Comment 3 youenn fablet 2019-01-14 15:46:47 PST 
Created attachment 359087 [details]
Patch
Comment 4 EWS Watchlist 2019-01-14 17:34:43 PST 
Comment on attachment 359087 [details]
Patch

Attachment 359087 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10750813

New failing tests:
inspector/worker/worker-create-and-terminate.html
inspector/unit-tests/target-manager.html
http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html
inspector/worker/resources-in-worker.html
inspector/page/searchInResources.html
Comment 5 EWS Watchlist 2019-01-14 17:34:45 PST 
Created attachment 359105 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 6 youenn fablet 2019-01-14 17:51:49 PST 
Created attachment 359108 [details]
Patch
Comment 7 Joseph Pecoraro 2019-01-15 15:50:15 PST 
Comment on attachment 359108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359108&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        - The run loop timer to be active and need to fire immediatly.

A few grammatical issues / typos in the ChangeLog. You could try giving it a cleanup pass.

Here: "The run loop timer is active and needs to fire immediately"

> Source/WebCore/workers/WorkerRunLoop.cpp:-118
> -        m_runLoop.m_nestedCount++;

I liked the older style, it was easier to follow when the increments happen because it is not clever.

> Source/WebCore/workers/WorkerRunLoop.h:92
> +        bool isBeingDebugged() const { return m_debugCount; }

I'd rather see a condition like `m_debugCount >= 1` but I'll leave that up to you.
Comment 8 youenn fablet 2019-01-16 10:26:16 PST 
Created attachment 359278 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-01-16 11:07:29 PST 
Comment on attachment 359278 [details]
Patch for landing

Clearing flags on attachment: 359278

Committed r240042: <https://trac.webkit.org/changeset/240042>
Comment 10 WebKit Commit Bot 2019-01-16 11:07:30 PST 
All reviewed patches have been landed.  Closing bug.