Bug 193359 – Prevent WorkerRunLoop::runInMode from spinning in nested cases

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

CacheStorage::Engine should create one engine for all ephemeral sessions

[youenn fablet]

<rdar://problem/46345353>

[youenn fablet]

Created attachment 359046 [details]
Patch

[youenn fablet]

Created attachment 359087 [details]
Patch

[EWS Watchlist]

Comment on attachment 359087 [details]
Patch

Attachment 359087 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10750813

New failing tests:
inspector/worker/worker-create-and-terminate.html
inspector/unit-tests/target-manager.html
http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html
inspector/worker/resources-in-worker.html
inspector/page/searchInResources.html

[EWS Watchlist]

Created attachment 359105 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[youenn fablet]

Created attachment 359108 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 359108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359108&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        - The run loop timer to be active and need to fire immediatly.

A few grammatical issues / typos in the ChangeLog. You could try giving it a cleanup pass.

Here: "The run loop timer is active and needs to fire immediately"

> Source/WebCore/workers/WorkerRunLoop.cpp:-118
> -        m_runLoop.m_nestedCount++;

I liked the older style, it was easier to follow when the increments happen because it is not clever.

> Source/WebCore/workers/WorkerRunLoop.h:92
> +        bool isBeingDebugged() const { return m_debugCount; }

I'd rather see a condition like `m_debugCount >= 1` but I'll leave that up to you.

[youenn fablet]

Created attachment 359278 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 359278 [details]
Patch for landing

Clearing flags on attachment: 359278

Committed r240042: <https://trac.webkit.org/changeset/240042>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.