Bug 193354 - Make "Disable Web SQL" on by default
Summary: Make "Disable Web SQL" on by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks: 193451
  Show dependency treegraph
 
Reported: 2019-01-11 11:15 PST by Sihui Liu
Modified: 2019-01-16 09:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2019-01-11 11:23 PST, Sihui Liu
no flags Details | Formatted Diff | Diff
Fix tests (1.83 KB, patch)
2019-01-14 18:07 PST, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-01-11 11:15:05 PST
Web SQL should be off now.
Comment 1 Sihui Liu 2019-01-11 11:15:43 PST
<rdar://problem/46524584>
Comment 2 Sihui Liu 2019-01-11 11:23:25 PST
Created attachment 358915 [details]
Patch
Comment 3 Geoffrey Garen 2019-01-11 14:18:52 PST
Comment on attachment 358915 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-01-11 17:00:21 PST
Comment on attachment 358915 [details]
Patch

Clearing flags on attachment: 358915

Committed r239885: <https://trac.webkit.org/changeset/239885>
Comment 5 WebKit Commit Bot 2019-01-11 17:00:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Truitt Savell 2019-01-14 14:52:18 PST
I found that the changes in https://trac.webkit.org/changeset/239885/webkit

has caused 2 API failure and 1 Timeout on Mac. 

Log:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run-api-tests/logs/stdio

Confirmed this using command:
run-api-tests --no-build --debug --root debug-239885

I got these failures with a spade with 239885 but none with 239884.
Comment 7 Sihui Liu 2019-01-14 16:20:47 PST
(In reply to Truitt Savell from comment #6)
> I found that the changes in https://trac.webkit.org/changeset/239885/webkit
> 
> has caused 2 API failure and 1 Timeout on Mac. 
> 
> Log:
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run-
> api-tests/logs/stdio
> 
> Confirmed this using command:
> run-api-tests --no-build --debug --root debug-239885
> 
> I got these failures with a spade with 239885 but none with 239884.

This failure should be harmless. We can either remove the WebSQL part or enable WebSQL in TestRunner.
Comment 8 Geoffrey Garen 2019-01-14 16:38:04 PST
Can we change the API tests to explicitly enable WebSQL when they run?
Comment 9 Sihui Liu 2019-01-14 18:06:20 PST
(In reply to Geoffrey Garen from comment #8)
> Can we change the API tests to explicitly enable WebSQL when they run?

We have (In reply to Geoffrey Garen from comment #8)
> Can we change the API tests to explicitly enable WebSQL when they run?

Yes, we can
Comment 10 Sihui Liu 2019-01-14 18:07:45 PST
Created attachment 359112 [details]
Fix tests
Comment 11 Sihui Liu 2019-01-15 08:54:18 PST
(In reply to Sihui Liu from comment #10)
> Created attachment 359112 [details]
> Fix tests

Patch cannot be tested after bug is closed... Fix in https://bugs.webkit.org/show_bug.cgi?id=193451