Bug 193352 – webkitpy: Print abbreviated baseline search path that includes only folders that exist

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Maciej mentioned this idea in passing, I think it's a good one given how long our baseline search paths have gotten (and the fact the impending device-specific expectations will likely make this problem worse).

[Radar WebKit Bug Importer]

<rdar://problem/47210736>

[Jonathan Bedard]

Created attachment 358901 [details]
Patch

[Ryan Haddad]

Comment on attachment 358901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358901&action=review

> Tools/ChangeLog:3
> +        webkitpy: Print abbreviated baseline search path that includes only folders that exists

Typo: Should be 'exist', not 'exists'

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:85
> +        full_baseline_search_paths = self._port.baseline_search_path()

For consistency, I think this should be 'full_baseline_search_path'.

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:88
> +        self._print_default('Verbose baseline search paths: {} -> generic'.format(' -> '.join(normalize_baseline(full_baseline_search_paths))))

Again, 'path' not 'paths'.

[Jonathan Bedard]

Created attachment 358903 [details]
Patch

[Jonathan Bedard]

Created attachment 358904 [details]
Patch

[Lucas Forschler]

Comment on attachment 358904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358904&action=review

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:86
> +        normalize_baseline = lambda basline_search_paths: [fs.relpath(x, self._port.layout_tests_dir()).replace("../", "") for x in basline_search_paths]

typo: basline

[Jonathan Bedard]

Created attachment 358909 [details]
Patch for landing

[Jonathan Bedard]

Committed r239874: <https://trac.webkit.org/changeset/239874>