Bug 193336 - Web Inspector: extend overlay element bounds lines to the right/below as well
Summary: Web Inspector: extend overlay element bounds lines to the right/below as well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 13:56 PST by Devin Rousso
Modified: 2019-01-16 11:57 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2019-01-10 13:58 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (625.11 KB, image/png)
2019-01-10 13:58 PST, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-01-10 13:56:16 PST 
Right now, we only show bounds lines above/left of the highlighted element.  We should also show lines below/right, so we can compare positioning with other elements (e.g. Flexbox alignment).
Comment 1 Devin Rousso 2019-01-10 13:58:22 PST 
Created attachment 358829 [details]
Patch
Comment 2 Devin Rousso 2019-01-10 13:58:37 PST 
Created attachment 358830 [details]
[Image] After Patch is applied
Comment 3 Matt Baker 2019-01-16 11:31:02 PST 
Comment on attachment 358829 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-01-16 11:56:40 PST 
Comment on attachment 358829 [details]
Patch

Clearing flags on attachment: 358829

Committed r240044: <https://trac.webkit.org/changeset/240044>
Comment 5 WebKit Commit Bot 2019-01-16 11:56:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-16 11:57:28 PST 
<rdar://problem/47324576>